From 22efd55b17e6c4d42133f90a7a5a430d2e2027c7 Mon Sep 17 00:00:00 2001
From: phamngocquy <phamngocquy@users.noreply.github.com>
Date: Fri, 31 Jul 2026 00:14:49 +0800
Subject: [PATCH] ci: two `test:ci` drift checks are never executed by any
 GitHub Actions job

Fixes #9649
---
 .github/workflows/ci.yml                       | 18 ++++++++++++++++++
 .../check-import-specifiers-script.test.ts     |  8 ++++++++
 2 files changed, 26 insertions(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f122e26c0d..4add59fbe9 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -49,6 +49,7 @@ jobs:
       rees: ${{ steps.filter.outputs.rees }}
       controlPlane: ${{ steps.filter.outputs.controlPlane }}
       observability: ${{ steps.filter.outputs.observability }}
+      cocoDev: ${{ steps.filter.outputs.cocoDev }}
     steps:
       # Debounce rapid re-pushes to an open PR: every job below (validate-code, validate-tests)
       # has `needs: changes` in its dependency chain, so none of
@@ -198,6 +199,9 @@ jobs:
             discoveryIndex:
               - 'packages/discovery-index/**'
               - 'package-lock.json'
+            cocoDev:
+              - 'k8s/coco-dev/**'
+              - 'scripts/check-coco-dev-versions*.ts'
             # 6 of the 7 MCP CLI-cluster test files, and ONLY these 6, are truly self-contained w.r.t. root
             # src/**: verified by direct-import inspection that test/unit/mcp-cli-*.test.ts (5 files) and
             # their shared test/unit/support/mcp-cli-harness.ts import nothing but node:* builtins + vitest,
@@ -400,6 +404,20 @@ jobs:
       - name: Dead source-file check
         if: ${{ github.event_name == 'push' || needs.changes.outputs.backend == 'true' }}
         run: npm run dead-source-files:check
+      # Same local-only-until-now gap as the drift checks above: coco-dev-versions:check was wired into
+      # `npm run test:ci` but nothing in this workflow previously ran it, so a version bump in only one of
+      # k8s/coco-dev/versions.json and k8s/coco-dev/kbs/base/kustomization.yaml could silently ship with zero
+      # CI signal (#9213).
+      - name: Coco-dev versions drift check
+        if: ${{ github.event_name == 'push' || needs.changes.outputs.cocoDev == 'true' }}
+        run: npm run coco-dev-versions:check
+      # Same local-only-until-now gap as the drift checks above: import-specifiers:check (#9221) was wired into
+      # `npm run test:ci` but nothing in this workflow previously ran it -- #9240 and #9249 are two separate
+      # relative-import drifts that reached main while the guard was local-only. Gated on every filter covering a
+      # packages/* workspace plus backend (src/scripts/test are under backend).
+      - name: Import specifiers check
+        if: ${{ github.event_name == 'push' || needs.changes.outputs.backend == 'true' || needs.changes.outputs.mcp == 'true' || needs.changes.outputs.engine == 'true' || needs.changes.outputs.miner == 'true' || needs.changes.outputs.discoveryIndex == 'true' }}
+        run: npm run import-specifiers:check
       # #9499: an agent-regate-pr producer that omits prCreatedAt does not merely lose the oldest-first
       # ordering, it INVERTS it -- the legacy sort fallback places such a job ahead of every real PR. Five of
       # eight producers had drifted that way before this check existed.
diff --git a/test/unit/check-import-specifiers-script.test.ts b/test/unit/check-import-specifiers-script.test.ts
index 070af6b078..3713f20d08 100644
--- a/test/unit/check-import-specifiers-script.test.ts
+++ b/test/unit/check-import-specifiers-script.test.ts
@@ -131,4 +131,12 @@ describe("check-import-specifiers script", () => {
     expect(multi.map((v) => v.file)).toEqual(["src/a.ts", "src/z.ts", "src/z.ts"]);
     expect(multi.map((v) => v.specifier)).toEqual(["./c.js", "./a.js", "./b.js"]);
   });
+
+  // Most important regression test in this file: the real repo must have zero import-specifier violations.
+  // #9240 and #9249 reached main while this guard was local-only; this closes the same gap the workflow
+  // step alone cannot (vitest runs unconditionally on every backend PR).
+  it("the real repo has zero import-specifier violations (regression guard)", () => {
+    const violations = findImportSpecifierViolations();
+    expect(violations).toEqual([]);
+  });
 });