Skip to content

Commit 87d60d2

Browse files
committed
Minor updates adhering to rules repository
1 parent b3de5c3 commit 87d60d2

3 files changed

Lines changed: 43 additions & 8 deletions

File tree

pom.xml

Lines changed: 32 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,17 +66,46 @@
6666
<!-- Integration Testing -->
6767

6868
<!-- BrowserStack Local bindings -->
69-
<!-- <dependency>
69+
<!-- <dependency>
7070
<groupId>com.browserstack</groupId>
7171
<artifactId>browserstack-local-java</artifactId>
72-
<version>LATEST</version>
72+
<version>1.1.7</version>
73+
<exclusions>
74+
<exclusion>
75+
<groupId>org.junit.platform</groupId>
76+
<artifactId>junit-platform-engine</artifactId>
77+
</exclusion>
78+
<exclusion>
79+
<groupId>org.junit.platform</groupId>
80+
<artifactId>junit-platform-commons</artifactId>
81+
</exclusion>
82+
<exclusion>
83+
<groupId>junit</groupId>
84+
<artifactId>junit</artifactId>
85+
</exclusion>
86+
</exclusions>
7387
</dependency>
7488
7589
<dependency>
7690
<groupId>com.browserstack</groupId>
7791
<artifactId>browserstack-java-sdk</artifactId>
78-
<version>LATEST</version>
92+
<version>1.46.0</version>
93+
<exclusions>
94+
<exclusion>
95+
<groupId>org.junit.platform</groupId>
96+
<artifactId>junit-platform-engine</artifactId>
97+
</exclusion>
98+
<exclusion>
99+
<groupId>org.junit.platform</groupId>
100+
<artifactId>junit-platform-commons</artifactId>
101+
</exclusion>
102+
<exclusion>
103+
<groupId>junit</groupId>
104+
<artifactId>junit</artifactId>
105+
</exclusion>
106+
</exclusions>
79107
</dependency>-->
108+
80109
<dependency>
81110
<groupId>com.guicedee</groupId>
82111
<artifactId>guiced-vertx-web</artifactId>

src/main/java/com/jwebmp/testing/BaseIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.jwebmp.testing;
22

33
import com.guicedee.guicedinjection.GuiceContext;
4-
import com.jwebmp.testing.browserstack.BrowserStackLocalExtension;
4+
//import com.jwebmp.testing.browserstack.BrowserStackLocalExtension;
55
import io.vertx.core.http.HttpServer;
66
import org.junit.jupiter.api.BeforeAll;
77
import org.junit.jupiter.api.DisplayName;
@@ -25,7 +25,7 @@
2525
import static org.junit.jupiter.api.Assertions.assertEquals;
2626
import static org.junit.jupiter.api.Assertions.assertTrue;
2727

28-
@ExtendWith(BrowserStackLocalExtension.class)
28+
//@ExtendWith(BrowserStackLocalExtension.class)
2929
public abstract class BaseIntegrationTest implements com.guicedee.vertx.web.spi.VertxHttpServerConfigurator
3030
{
3131
@BeforeAll

src/main/java/com/jwebmp/testing/browserstack/BrowserStackLocalExtension.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/*
12
package com.jwebmp.testing.browserstack;
23
34
import com.browserstack.local.Local;
@@ -12,6 +13,7 @@
1213
import java.util.Optional;
1314
import java.util.stream.Collectors;
1415
16+
*/
1517
/**
1618
* JUnit 5 extension that manages the lifecycle of BrowserStack Local.
1719
*
@@ -28,7 +30,8 @@
2830
* - browserstack.force / BROWSERSTACK_FORCE => "true" to force kill others
2931
* - browserstack.onlyAutomate / BROWSERSTACK_ONLY_AUTOMATE => "true" only automate
3032
* - proxyHost/Port/User/Pass via browserstack.proxyHost, etc (or env)
31-
*/
33+
*//*
34+
3235
public class BrowserStackLocalExtension implements BeforeEachCallback, AfterEachCallback, ExecutionCondition {
3336
3437
private static void log(String msg) {
@@ -112,12 +115,14 @@ private static void putIfPresent(Map<String, String> map, String k, String v) {
112115
map.put(k, v);
113116
}
114117
115-
/**
118+
*/
119+
/**
116120
* Resolves the BrowserStack access key using precedence:
117121
* 1) System property browserstack.accessKey
118122
* 2) Environment variable BROWSERSTACK_ACCESS_KEY
119123
* 3) browserstack.yml on classpath (key: accessKey)
120-
*/
124+
*//*
125+
121126
private static String resolveAccessKey() {
122127
String v = get("browserstack.accessKey", "BROWSERSTACK_ACCESS_KEY");
123128
if (v != null && !v.isBlank()) {
@@ -162,3 +167,4 @@ private static String readAccessKeyFromYml() {
162167
}
163168
}
164169
}
170+
*/

0 commit comments

Comments
 (0)