Skip to content

feat: use captureStr#2

Open
fgdorais wants to merge 6 commits into
JamesGallicchio:mainfrom
fgdorais:capture
Open

feat: use captureStr#2
fgdorais wants to merge 6 commits into
JamesGallicchio:mainfrom
fgdorais:capture

Conversation

@fgdorais
Copy link
Copy Markdown
Contributor

I thought your parser capture idea was really cool, so I added it to lean4-parser. Since I grabbed the name, this breaks your code. Here are proposed fixes.

@fgdorais
Copy link
Copy Markdown
Contributor Author

fgdorais commented Dec 23, 2023

I'm thinking I was too quick picking this capture API. I think you're use case where the parser output is dropped is probably a primary use. I'm thinking about revising the API with two interfaces: withCapture and dropCapture. What do you think? That way, dropCaptureString would be a drop-in replacement for your original capture parser.

@fgdorais fgdorais changed the title feat: use captureString feat: use captureStr Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants