Skip to content

Feature clicking issue#4

Open
dchen116 wants to merge 40 commits into
JaneliaSciComp:janelia/janelia_workfrom
dchen116:FeatureClickingIssue
Open

Feature clicking issue#4
dchen116 wants to merge 40 commits into
JaneliaSciComp:janelia/janelia_workfrom
dchen116:FeatureClickingIssue

Conversation

@dchen116
Copy link
Copy Markdown
Contributor

@dchen116 dchen116 commented Apr 23, 2024

Issue Overview:

The earlier version of MIPAV faced issues with inaccurate user interactions, especially related to mode switching and plot handling, which impacted user experience and data accuracy.

Solutions:

  • Improved Interaction Accuracy: Added an AccurateModeButton with a keyboard shortcut ('M') for toggling between precise and color modes, enhancing control and interaction flexibility.

  • Enhanced Plot Management: Introduced a SelectionChartPanel class to consolidate chart functionalities, supporting better code organization and modularity. Enhanced plot markers to respond dynamically to user interactions, reflecting real-time updates on the 3D model.

  • UI Improvements: Fixed unwanted plot zooming issues and improved visual cues such as tooltips and marker adjustments for better visibility and interaction.

  • Code Refinement: Streamlined code by removing redundancies, adding detailed comments, and improving method structures for better maintainability.

1
2

dchen116 and others added 22 commits April 23, 2024 10:07
PickVolum3D were retrieved to replace the current one.
PickVolum3D were retrieved to replace the current one. An valueOutput
class was created for output the data into csv files for plotting.
by press key "M" or "m".toggleAccurateMode() and isAccurateMode() is
created.
vs 3 color mode(inaccurate clicking) with its actionListener
3 color mode (inaccurate currently) with its actionListener.
Comment thread src/gov/nih/mipav/view/renderer/WildMagic/VolumeTriPlanarRender.java Outdated
Comment thread src/gov/nih/mipav/view/renderer/WildMagic/VolumeTriPlanarRender.java Outdated
Comment thread src/gov/nih/mipav/view/renderer/WildMagic/VolumeTriPlanarRender.java Outdated
import javax.swing.JTextArea;
import javax.swing.JTextField;

public class BatchProcessLogFrame implements ActionListener {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For BatchProcessLogFrame we should consider cherry-picking this.

https://git-scm.com/docs/git-cherry-pick

Comment thread src/org/janelia/mipav/plugins/worm/untwisting/PlotListener.java Outdated
Comment thread test/org/janelia/mipav/test/ValueOutput.java Outdated
Copy link
Copy Markdown
Collaborator

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above. Basically:

  1. Remove elements that we were using mainly for debugging
  2. Use more specific names to describe what we are doing.
  3. Add documentation and comments to explain the changes.

Copy link
Copy Markdown
Collaborator

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all println that does not need to exist.

Comment thread src/gov/nih/mipav/view/renderer/WildMagic/VOI/VOILatticeManagerInterface.java Outdated
Comment thread src/org/janelia/mipav/plugins/worm/untwisting/SelectionChartPanel.java Outdated
@mkitti
Copy link
Copy Markdown
Collaborator

mkitti commented Jun 12, 2024

We need to move the JFreeChart jar file into the lib directory and add it to git.

@dchen116 dchen116 marked this pull request as ready for review June 28, 2024 19:13
@dchen116 dchen116 requested a review from mkitti June 28, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants