Skip to content

Commit 2138260

Browse files
authored
[BugFix] Remove -Werror from csrc CMakeLists.txt files (vllm-project#13091)
## Motivation In the new version of CANN, alarms will be generated. Using -werror will cause the alarms to be treated as errors, resulting in installation failure. The `-Werror` flag in `csrc/**/op_host/CMakeLists.txt` files treats all compiler warnings as fatal errors. This blocks local development builds when the CANN compiler emits benign warnings (e.g., deprecated-declarations that are already silenced via `-Wno-deprecated-declarations`). Warnings should be reviewed and fixed, but they should not be fatal during development iteration. ## Modifications Removed the `-Werror` flag from all AscendC custom op `CMakeLists.txt` files under `csrc/`. This is a pure build-flag change — no source code or kernel logic is touched. - **43 files changed**, 43 deletions (one `-Werror` line per file) - The `-Wno-deprecated-declarations` flag and all other compile options remain unchanged ## Test No functional change. Build verification on target CANN toolchain recommended. - vLLM version: v0.25.1 - vLLM main: vllm-project/vllm@d02df74 Signed-off-by: ZT-AIA <1028681969@qq.com>
1 parent 3d0f7d6 commit 2138260

44 files changed

Lines changed: 0 additions & 44 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

csrc/attention/compressor/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ add_ops_compile_options(
1919
OP_NAME Compressor
2020
OPTIONS --cce-auto-sync=off
2121
-Wno-deprecated-declarations
22-
-Werror
2322
-mllvm -cce-aicore-hoist-movemask=false
2423
--op_relocatable_kernel_binary=true
2524
)

csrc/attention/compressor_metadata/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ add_ops_compile_options(
2020
OP_NAME CompressorMetadata
2121
OPTIONS --cce-auto-sync=off
2222
-Wno-deprecated-declarations
23-
-Werror
2423
-mllvm -cce-aicore-hoist-movemask=false
2524
--op_relocatable_kernel_binary=true
2625
)

csrc/attention/indexer_compress_epilog/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ add_ops_compile_options(
5353
OP_NAME IndexerCompressEpilog
5454
OPTIONS --cce-auto-sync=off
5555
-Wno-deprecated-declarations
56-
-Werror
5756
-mllvm -cce-aicore-hoist-movemask=false
5857
--op_relocatable_kernel_binary=true
5958
)

csrc/attention/indexer_compress_epilog_v2/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ add_ops_compile_options(
5454
OP_NAME IndexerCompressEpilogV2
5555
OPTIONS --cce-auto-sync=off
5656
-Wno-deprecated-declarations
57-
-Werror
5857
-mllvm -cce-aicore-hoist-movemask=false
5958
--op_relocatable_kernel_binary=true
6059
)

csrc/attention/inplace_partial_rotary_mul/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ add_ops_compile_options(
6464
OP_NAME InplacePartialRotaryMul
6565
OPTIONS --cce-auto-sync=on
6666
-Wno-deprecated-declarations
67-
-Werror
6867
-mllvm -cce-aicore-hoist-movemask=false
6968
--op_relocatable_kernel_binary=true
7069
)

csrc/attention/kv_compress_epilog/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ add_ops_compile_options(
4949
OP_NAME KvCompressEpilog
5050
OPTIONS --cce-auto-sync=off
5151
-Wno-deprecated-declarations
52-
-Werror
5352
-mllvm -cce-aicore-hoist-movemask=false
5453
--op_relocatable_kernel_binary=true
5554
)

csrc/attention/kv_quant_sparse_attn_sharedkv/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ add_ops_compile_options(
2020
OP_NAME KvQuantSparseAttnSharedkv
2121
OPTIONS --cce-auto-sync=off
2222
-Wno-deprecated-declarations
23-
-Werror
2423
-mllvm -cce-vf-remove-membar=false
2524
-mllvm -cce-aicore-hoist-movemask=false
2625
)

csrc/attention/kv_quant_sparse_flash_attention/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ add_ops_compile_options(
2222
OP_NAME KvQuantSparseFlashAttention
2323
OPTIONS --cce-auto-sync=off
2424
-Wno-deprecated-declarations
25-
-Werror
2625
-mllvm -cce-vf-remove-membar=false
2726
-mllvm -cce-aicore-hoist-movemask=false
2827
)

csrc/attention/lightning_indexer/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ add_ops_compile_options(
1919
OP_NAME LightningIndexer
2020
OPTIONS --cce-auto-sync=off
2121
-Wno-deprecated-declarations
22-
-Werror
2322
-mllvm -cce-vf-remove-membar=false
2423
-mllvm -cce-aicore-hoist-movemask=false
2524
)

csrc/attention/lightning_indexer_quant/op_host/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ add_ops_compile_options(
1111
OPTIONS
1212
--cce-auto-sync=off
1313
-Wno-deprecated-declarations
14-
-Werror
1514
-mllvm -cce-aicore-hoist-movemask=false
1615
--op_relocatable_kernel_binary=true
1716
)

0 commit comments

Comments
 (0)