Skip to content

Commit 77adc06

Browse files
[CI] Fix third-party validation: fix dorny/paths-filter YAML unclosed quotes, add continue-on-error for peter-evans comment on fork PRs
1 parent 29134e0 commit 77adc06

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/validate_third_party_actions.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@ jobs:
6666
workflows:
6767
- '.github/workflows/**'
6868
source:
69-
- 'vllm_ascend/**
70-
- 'csrc/**
69+
- 'vllm_ascend/**'
70+
- 'csrc/**'
7171
- 'setup.py'
7272
docs:
73-
- 'docs/**
73+
- 'docs/**'
7474
- '*.md'
7575
tests:
7676
- 'tests/**'
@@ -186,6 +186,7 @@ jobs:
186186
187187
- name: peter-evans/create-or-update-comment
188188
id: comment
189+
continue-on-error: true
189190
uses: peter-evans/create-or-update-comment@v5
190191
with:
191192
issue-number: ${{ github.event.pull_request.number }}
@@ -213,7 +214,7 @@ jobs:
213214
echo "Comment URL: ${{ steps.comment.outputs.comment-url }}"
214215
215216
- name: Comment post failed notification
216-
if: steps.comment.outputs.comment-id == ''
217+
if: always() && steps.comment.outputs.comment-id == ''
217218
run: |
218219
echo "::warning::peter-evans/create-or-update-comment did not return a comment-id. Check if this is a fork PR (GITHUB_TOKEN may lack write permission)."
219220
echo "Outcome: ${{ steps.comment.outcome }}"

0 commit comments

Comments
 (0)