Skip to content

Commit edcae83

Browse files
[Misc] main2main upgrade vllm to v0.23.0 (vllm-project#10534)
### What this PR does / why we need it? This PR upgrades the default vLLM version for the vllm-ascend project from v0.22.1 to v0.23.0, and re-enables release-tag CI testing. **1. vLLM Version Update** - Updated `.github/vllm-release-tag.commit` to `v0.23.0` - Updated default `VLLM_TAG` to `v0.23.0` in all Dockerfiles (`Dockerfile`, `Dockerfile.310p`, `Dockerfile.a3`, `Dockerfile.a5`, and their openEuler variants) - Updated version references in documentation **2. CI Workflow Optimization** - Re-enabled release-tag CI testing: - `pr_e2e_command.yml`: Restored release-tag test matrix - `pr_test.yaml`: Restored release-tag test matrix - `schedule_update_estimated_times.yaml`: Restored release-tag scheduled job and timing updates - `schedule_vllm_e2e_test.yaml`: Re-enabled weekly upstream E2E test schedule **3. v2 Model Runner Compatibility Handling** Due to API differences between vLLM v0.23.0 and main branch, v2 model runner patches are only supported on main branch: - Added `_V2_MODEL_RUNNER_SUPPORTED` flag in `vllm_ascend/patch/worker/__init__.py` - Added fallback logic in `vllm_ascend/worker/worker.py` to automatically fall back to v1 when v2 model runner is set on v0.23.0 - Updated related tests to skip v2 model runner tests on v0.23.0 **4. Documentation Updates** - Updated branch status in `README.md` and `README.zh.md` to indicate main branch supports CI coverage for both vLLM main and v0.23.0 - Updated example branch name in `docs/source/community/slash-commands.md` ### Does this PR introduce _any_ user-facing change? Yes. Users must upgrade their upstream vLLM installation to v0.23.0. This release of vllm-ascend is **not** compatible with vLLM v0.22.1 or earlier. The `VLLM_USE_V2_MODEL_RUNNER` flag remains unsupported on the v0.23.0 release tag (only supported on vLLM main). ### How was this patch tested? full test https://github.com/vllm-project/vllm-ascend/actions/runs/27616069133/job/81653220088?pr=10534 https://github.com/vllm-project/vllm-ascend/actions/runs/27665474683/job/81818968014?pr=10534 https://github.com/vllm-project/vllm-ascend/actions/runs/28016862824/job/82923233743?pr=10534 https://github.com/vllm-project/vllm-ascend/actions/runs/28073790792/job/83114305076?pr=10534 - vLLM version: v0.22.1 - vLLM main: vllm-project/vllm@967c5c3 --------- Signed-off-by: liyishi <1252651434@qq.com>
1 parent 2351a22 commit edcae83

23 files changed

Lines changed: 66 additions & 56 deletions

.github/vllm-release-tag.commit

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v0.22.1
1+
v0.23.0

.github/workflows/pr_e2e_command.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,10 +181,7 @@ jobs:
181181
matrix:
182182
vllm_version:
183183
- ${{ needs.e2e-test.outputs.main_commit }}
184-
# Dropped vLLM v0.22.1 (release-tag) compatibility from main. Uncomment
185-
# the line below to re-enable release-tag e2e when maintaining a new
186-
# release tag (update .github/vllm-release-tag.commit accordingly).
187-
# - ${{ needs.e2e-test.outputs.release_tag }}
184+
- ${{ needs.e2e-test.outputs.release_tag }}
188185
needs: [e2e-test]
189186
if: ${{ needs.e2e-test.outputs.has_tests == 'true' }}
190187
uses: ./.github/workflows/_selected_tests.yaml

.github/workflows/pr_test.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,7 @@ jobs:
207207
matrix:
208208
vllm_version:
209209
- ${{ needs.lint-and-select-tests.outputs.main_commit }}
210-
# Dropped vLLM v0.22.1 (release-tag) compatibility from main. Uncomment
211-
# the line below to re-enable release-tag CI when maintaining a new
212-
# release tag (update .github/vllm-release-tag.commit accordingly).
213-
# - ${{ needs.lint-and-select-tests.outputs.release_tag }}
210+
- ${{ needs.lint-and-select-tests.outputs.release_tag }}
214211
uses: ./.github/workflows/_selected_tests.yaml
215212
with:
216213
vllm: ${{ matrix.vllm_version }}

.github/workflows/schedule_update_estimated_times.yaml

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -109,22 +109,18 @@ jobs:
109109
upload_timing: true
110110
continue_on_error: true
111111

112-
# Dropped vLLM v0.22.1 (release-tag) compatibility from main. Uncomment this
113-
# job to re-enable release-tag timing collection when maintaining a new
114-
# release tag (update .github/vllm-release-tag.commit accordingly).
115-
# run-tests-release:
116-
# needs: select-tests
117-
# if: ${{ needs.select-tests.outputs.has_tests == 'true' }}
118-
# uses: ./.github/workflows/_selected_tests.yaml
119-
# with:
120-
# vllm: ${{ needs.select-tests.outputs.release_tag }}
121-
# test_groups: ${{ needs.select-tests.outputs.test_groups }}
122-
# upload_timing: true
123-
# continue_on_error: true
112+
run-tests-release:
113+
needs: select-tests
114+
if: ${{ needs.select-tests.outputs.has_tests == 'true' }}
115+
uses: ./.github/workflows/_selected_tests.yaml
116+
with:
117+
vllm: ${{ needs.select-tests.outputs.release_tag }}
118+
test_groups: ${{ needs.select-tests.outputs.test_groups }}
119+
upload_timing: true
120+
continue_on_error: true
124121

125122
update-estimated-times:
126-
needs: [run-tests-main]
127-
# needs: [run-tests-main, run-tests-release]
123+
needs: [run-tests-main, run-tests-release]
128124
if: always()
129125
runs-on: ubuntu-latest
130126
steps:

.github/workflows/schedule_vllm_e2e_test.yaml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,8 @@
1818
name: E2E-upstream
1919

2020
on:
21-
# Dropped vLLM v0.22.1 (release-tag) compatibility from main. This workflow
22-
# runs vllm-ascend main against the v0.22.1 release tag and would now fail, so
23-
# the weekly schedule is disabled (left manually runnable via workflow_dispatch).
24-
# Re-enable the cron below and update .github/vllm-release-tag.commit when
25-
# maintaining a new release tag.
26-
workflow_dispatch:
27-
# schedule:
28-
# - cron: '0 8 * * 0' # every Sunday at 8:00
21+
schedule:
22+
- cron: '0 8 * * 0' # every Sunday at 8:00
2923
# Bash shells do not use ~/.profile or ~/.bashrc so these shells need to be explicitly
3024
# declared as "shell: bash -el {0}" on steps that need to be properly activated.
3125
# It's used to activate ascend-toolkit environment variables.

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ RUN pip config set global.index-url ${PIP_INDEX_URL} && \
4747

4848
# Install vLLM
4949
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
50-
ARG VLLM_TAG=v0.22.1
50+
ARG VLLM_TAG=v0.23.0
5151
ARG VLLM_COMMIT=""
5252
RUN if [ -n "$VLLM_COMMIT" ]; then \
5353
git init /vllm-workspace/vllm && \

Dockerfile.310p

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ RUN pip config set global.index-url ${PIP_INDEX_URL} && \
3333

3434
# Install vLLM
3535
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
36-
ARG VLLM_TAG=v0.22.1
36+
ARG VLLM_TAG=v0.23.0
3737
ARG VLLM_COMMIT=""
3838
RUN if [ -n "$VLLM_COMMIT" ]; then \
3939
git init /vllm-workspace/vllm && \

Dockerfile.310p.openEuler

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ RUN pip config set global.index-url ${PIP_INDEX_URL} && \
3232

3333
# Install vLLM
3434
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
35-
ARG VLLM_TAG=v0.22.1
35+
ARG VLLM_TAG=v0.23.0
3636
ARG VLLM_COMMIT=""
3737
RUN if [ -n "$VLLM_COMMIT" ]; then \
3838
git init /vllm-workspace/vllm && \

Dockerfile.a3

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ RUN pip config set global.index-url ${PIP_INDEX_URL} && \
4949

5050
# Install vLLM
5151
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
52-
ARG VLLM_TAG=v0.22.1
52+
ARG VLLM_TAG=v0.23.0
5353
ARG VLLM_COMMIT=""
5454
RUN if [ -n "$VLLM_COMMIT" ]; then \
5555
git init /vllm-workspace/vllm && \

Dockerfile.a3.openEuler

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ RUN pip config set global.index-url ${PIP_INDEX_URL} && \
4747

4848
# Install vLLM
4949
ARG VLLM_REPO=https://github.com/vllm-project/vllm.git
50-
ARG VLLM_TAG=v0.22.1
50+
ARG VLLM_TAG=v0.23.0
5151
ARG VLLM_COMMIT=""
5252
RUN if [ -n "$VLLM_COMMIT" ]; then \
5353
git init /vllm-workspace/vllm && \

0 commit comments

Comments
 (0)