Commit f926eea
authored
[BugFix][KVTransfer] Fix Mooncake split metadata group ids (vllm-project#11439)
## What this PR does / why we need it?
This PR fixes Mooncake KV split metadata generation for hybrid PD
disaggregation scenarios where Mooncake transfer groups do not have a
one-to-one mapping with KV cache manager groups.
PR vllm-project#10991 split Mooncake transfer groups by KV spec and preserved the
original KV cache manager group in `kv_cache_group_id`. PR vllm-project#10590 later
moved kernel block expansion into `_get_kv_split_metadata`, but that
path still indexed `local_block_ids` and `remote_block_ids` with the
transfer group id. For hybrid models such as Kimi, this can make a Mamba
or split attention transfer group index past the original KV cache group
block-id tuple.
The fix maps each transfer group back through `kv_cache_group_id` before
reading or writing split metadata block ids, covering both no-CP and
PCP/DCP paths.
## Does this PR introduce _any_ user-facing change?
No user-facing API change. It fixes internal Mooncake KV transfer
metadata generation for hybrid PD scenarios.
## How was this patch tested?
CI and Unit tests.
Unit tests:
```bash
uv run pytest -q tests/ut/kv_offload/test_mooncake_connector.py
```
Result: 93 passed, 22 subtests passed.
- vLLM version: v0.23.0
- vLLM main:
vllm-project/vllm@1f486d9
---------
Signed-off-by: zhuyixiang <zhuyixiang2014@163.com>1 parent c120dad commit f926eea
2 files changed
Lines changed: 93 additions & 7 deletions
File tree
- tests/ut/kv_offload
- vllm_ascend/distributed/kv_transfer/kv_p2p
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2647 | 2647 | | |
2648 | 2648 | | |
2649 | 2649 | | |
| 2650 | + | |
| 2651 | + | |
| 2652 | + | |
| 2653 | + | |
| 2654 | + | |
| 2655 | + | |
| 2656 | + | |
| 2657 | + | |
| 2658 | + | |
| 2659 | + | |
| 2660 | + | |
| 2661 | + | |
| 2662 | + | |
| 2663 | + | |
| 2664 | + | |
| 2665 | + | |
| 2666 | + | |
| 2667 | + | |
| 2668 | + | |
| 2669 | + | |
| 2670 | + | |
| 2671 | + | |
| 2672 | + | |
| 2673 | + | |
| 2674 | + | |
| 2675 | + | |
| 2676 | + | |
| 2677 | + | |
| 2678 | + | |
| 2679 | + | |
| 2680 | + | |
| 2681 | + | |
| 2682 | + | |
| 2683 | + | |
| 2684 | + | |
| 2685 | + | |
| 2686 | + | |
| 2687 | + | |
| 2688 | + | |
| 2689 | + | |
| 2690 | + | |
| 2691 | + | |
| 2692 | + | |
| 2693 | + | |
| 2694 | + | |
| 2695 | + | |
| 2696 | + | |
| 2697 | + | |
| 2698 | + | |
| 2699 | + | |
| 2700 | + | |
| 2701 | + | |
| 2702 | + | |
| 2703 | + | |
| 2704 | + | |
| 2705 | + | |
| 2706 | + | |
| 2707 | + | |
| 2708 | + | |
| 2709 | + | |
| 2710 | + | |
| 2711 | + | |
| 2712 | + | |
| 2713 | + | |
| 2714 | + | |
| 2715 | + | |
| 2716 | + | |
| 2717 | + | |
| 2718 | + | |
| 2719 | + | |
| 2720 | + | |
| 2721 | + | |
| 2722 | + | |
| 2723 | + | |
| 2724 | + | |
| 2725 | + | |
| 2726 | + | |
| 2727 | + | |
| 2728 | + | |
| 2729 | + | |
2650 | 2730 | | |
2651 | 2731 | | |
2652 | 2732 | | |
| |||
Lines changed: 13 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2434 | 2434 | | |
2435 | 2435 | | |
2436 | 2436 | | |
| 2437 | + | |
| 2438 | + | |
| 2439 | + | |
| 2440 | + | |
2437 | 2441 | | |
2438 | 2442 | | |
2439 | 2443 | | |
| |||
2442 | 2446 | | |
2443 | 2447 | | |
2444 | 2448 | | |
| 2449 | + | |
2445 | 2450 | | |
2446 | | - | |
| 2451 | + | |
2447 | 2452 | | |
2448 | 2453 | | |
2449 | 2454 | | |
| |||
2455 | 2460 | | |
2456 | 2461 | | |
2457 | 2462 | | |
2458 | | - | |
2459 | | - | |
| 2463 | + | |
| 2464 | + | |
2460 | 2465 | | |
2461 | 2466 | | |
2462 | 2467 | | |
| |||
2551 | 2556 | | |
2552 | 2557 | | |
2553 | 2558 | | |
2554 | | - | |
2555 | | - | |
| 2559 | + | |
| 2560 | + | |
2556 | 2561 | | |
2557 | 2562 | | |
2558 | 2563 | | |
2559 | 2564 | | |
2560 | | - | |
2561 | | - | |
| 2565 | + | |
| 2566 | + | |
| 2567 | + | |
2562 | 2568 | | |
2563 | 2569 | | |
2564 | 2570 | | |
| |||
0 commit comments