Skip to content

Commit bde2ec0

Browse files
fix(node-ci): exclude vendored tree via config, not deletion (#26)
Replace the rm of .github-workflows with reliance on default excludes in consuming projects (shared eslint/ktlint ignores, scaffolded .gitignore honoured by antfu-eslint, and .prettierignore). Keeps the CI checkout immutable and lets local runs and templates benefit from the same exclusion, instead of a workflow-only side effect. Co-authored-by: Agents Agent <agents@jorisjonkers.dev>
1 parent 2f339a5 commit bde2ec0

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

.github/workflows/node-ci.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,10 @@ jobs:
105105
install-command: ${{ inputs.install-command }}
106106
github-packages-token: ${{ secrets.packages-token || github.token }}
107107

108-
# The vendored actions repo is only needed for setup-node above. Remove it before any
109-
# quality command runs so workspace-wide linters/formatters (e.g. `eslint .`, `prettier
110-
# --check .`) only ever see the consuming project's own files, never this CI machinery.
111-
- name: Remove vendored CI actions before quality checks
112-
run: rm -rf .github-workflows
108+
# The vendored actions tree lives at .github-workflows/. Consuming projects exclude it from
109+
# linting/formatting by default (it is in the shared eslint/ktlint config ignores, the
110+
# scaffolded .gitignore — which antfu-eslint honours — and .prettierignore), so quality
111+
# commands see only the project's own files without this workflow mutating the checkout.
113112

114113
- name: Package check
115114
if: ${{ inputs.package-check-command != '' }}

0 commit comments

Comments
 (0)