Skip to content

Fails to format julia@1.12.6 #1024

@penelopeysm

Description

@penelopeysm
git clone git@github.com:JuliaLang/julia.git
cd julia
git checkout v1.12.6
git clean -xfd # not really needed but just in case
jlfmt --check . > julia_errors.txt 2>&1

yields the following six errors, which I'm currently trying to minimise & file separate issues for:

1 (#1025)

┌ Warning: Formatted text is not parsable ... no change made.
└ @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/JuliaFormatter.jl:280
ERROR: failed to parse input from ./Compiler/src/typelimits.jl: ParseError:
# Error @ line 688:19
                tyi = bi
#                 ┌
            elseif
            (tyi′ = tmerge_field(𝕃, ai, bi); tyi′ !== nothing)
#──────────┘ ── missing condition in `elseif`

2

┌ Warning: Formatted text is not parsable ... no change made.
└ @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/JuliaFormatter.jl:280
ERROR: failed to parse input from ./base/exports.jl: ParseError:
# Error @ line 347:5
    ~,
#   ┌
    :
    ,
#──┘ ── expected identifier

3

This is a variation of #1017

┌ Warning: Formatted text is not parsable ... no change made.
└ @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/JuliaFormatter.jl:280
ERROR: failed to parse input from ./stdlib/Libdl/test/runtests.jl: ParseError:
# Error @ line 321:9
            on_load_callback = () -> global lclb_loaded = true,
        )
#       ╙ ── unexpected `)`

4

┌ Warning: Formatted text is not parsable ... no change made.
└ @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/JuliaFormatter.jl:280
ERROR: failed to parse input from ./stdlib/REPL/src/LineEdit.jl: ParseError:
# Error @ line 772:22
        if curs_row >= 0 && cur_row + 1 >= rows &&             # when too many lines, cur_row - curs_row + 1 >= rows ÷ 2 # center the cursor
            lastline = true
#                    ╙ ── unexpected `=`

5

┌ Warning: Error occurred during prettification
│   line = 1442
│   offset = 8
│   goffset = 62342
└ @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/JuliaFormatter.jl:223
ERROR: failed to format input from ./test/subtype.jl: unexpected number of args for operator node6JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"<:", 0x0000), 0x0000003b, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"<:", 0x0001), 0x00000002, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"(", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"curly", 0x0000), 0x0000001d, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000003, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"{", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"where", 0x0000), 0x00000018, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"curly", 0x0000), 0x00000010, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000006, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"{", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"curly", 0x0000), 0x00000008, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000005, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"{", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"}", 0x0001), 0x00000001, nothing)]), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"}", 0x0001), 0x00000001, nothing)]), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Whitespace", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"where", 0x0001), 0x00000005, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Whitespace", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000001, nothing)]), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"}", 0x0001), 0x00000001, nothing)]), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K",", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"where", 0x0000), 0x00000019, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Whitespace", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"curly", 0x0000), 0x00000010, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000003, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"{", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"<:", 0x0010), 0x0000000b, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"<:", 0x0001), 0x00000002, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"curly", 0x0000), 0x00000009, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000006, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"{", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"}", 0x0001), 0x00000001, nothing)])]), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"}", 0x0001), 0x00000001, nothing)]), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Whitespace", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"where", 0x0001), 0x00000005, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Whitespace", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000001, nothing)]), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K")", 0x0001), 0x00000001, nothing)])
Stacktrace:
 [1] error(::String, ::Int64, ::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead})
   @ Base ./error.jl:54
 [2] source_operator_indices(cst::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead})
   @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/styles/default/pretty.jl:224
 [3] p_binaryopcall(ds::JuliaFormatter.DefaultStyle, cst::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}, s::JuliaFormatter.State, ctx::JuliaFormatter.PrettyContext, lineage::Vector{Tuple{JuliaSyntax.Kind, Bool, Bool}})
   @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/styles/default/pretty.jl:2294
 [4] pretty(ds::JuliaFormatter.DefaultStyle, node::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}, s::JuliaFormatter.State, ctx::JuliaFormatter.PrettyContext, lineage::Vector{Tuple{JuliaSyntax.Kind, Bool, Bool}})
   @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/styles/default/pretty.jl:434
 [5] p_unaryopcall(ds::JuliaFormatter.DefaultStyle, cst::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}, s::JuliaFormatter.State, ctx::JuliaFormatter.PrettyContext, lineage::Vector{Tuple{JuliaSyntax.Kind, Bool, Bool}}, is_prefix::Bool)
   @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/styles/default/pretty.jl:2707

6

┌ Warning: Error occurred during prettification
│   line = 1290
│   offset = 10
│   goffset = 40966
└ @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/JuliaFormatter.jl:223
ERROR: failed to format input from ./test/syntax.jl: unexpected number of args for operator node4JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"<:", 0x0000), 0x0000000c, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Whitespace", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"<:", 0x0001), 0x00000002, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"(", 0x0001), 0x00000001, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"...", 0x0000), 0x00000007, JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}[JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"Identifier", 0x0000), 0x00000004, nothing), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K"...", 0x0001), 0x00000003, nothing)]), JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}(JuliaSyntax.SyntaxHead(K")", 0x0001), 0x00000001, nothing)])
Stacktrace:
 [1] error(::String, ::Int64, ::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead})
   @ Base ./error.jl:54
 [2] source_operator_indices(cst::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead})
   @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/styles/default/pretty.jl:224
 [3] p_binaryopcall(ds::JuliaFormatter.DefaultStyle, cst::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}, s::JuliaFormatter.State, ctx::JuliaFormatter.PrettyContext, lineage::Vector{Tuple{JuliaSyntax.Kind, Bool, Bool}})
   @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/styles/default/pretty.jl:2294
 [4] pretty(ds::JuliaFormatter.DefaultStyle, node::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}, s::JuliaFormatter.State, ctx::JuliaFormatter.PrettyContext, lineage::Vector{Tuple{JuliaSyntax.Kind, Bool, Bool}})
   @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/styles/default/pretty.jl:424
 [5] p_macrocall(ds::JuliaFormatter.DefaultStyle, cst::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}, s::JuliaFormatter.State, ctx::JuliaFormatter.PrettyContext, lineage::Vector{Tuple{JuliaSyntax.Kind, Bool, Bool}})
   @ JuliaFormatter ~/jl/others/JuliaFormatter.jl/src/styles/default/pretty.jl:933

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions