From 46a8e8c92674b6777112363802a7d3555fb9b8b0 Mon Sep 17 00:00:00 2001 From: Michal Babej Date: Thu, 5 Mar 2026 15:02:01 +0200 Subject: [PATCH 1/2] re-enable some FP16 tests on PoCL MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These tests should work on the CI after https://github.com/pocl/pocl/pull/2128 lands in PoCL. Currently it's failing with errors like: Error During Test at /home/runner/work/pocl/pocl/OpenCL.jl/test/intrinsics.jl:116 Unexpected Pass Expression: call_on_device(f, x, y) ≈ f(x, y) Got correct result, please change to @test if no longer broken. --- test/intrinsics.jl | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/intrinsics.jl b/test/intrinsics.jl index 47075df9..57b0d447 100644 --- a/test/intrinsics.jl +++ b/test/intrinsics.jl @@ -96,8 +96,7 @@ end if f == acosh x += 1 end - broken = ispocl && T == Float16 && f in [acosh, asinh, atanh, cbrt, cospi, expm1, log1p, sinpi, tanpi] - @test call_on_device(f, x) ≈ f(x) broken = broken + @test call_on_device(f, x) ≈ f(x) end end @@ -112,8 +111,7 @@ end ] x = rand(T) y = rand(T) - broken = ispocl && T == Float16 && f == atan - @test call_on_device(f, x, y) ≈ f(x, y) broken = broken + @test call_on_device(f, x, y) ≈ f(x, y) end end @@ -138,7 +136,7 @@ end OpenCL.rsqrt, ] x = rand(T) - broken = ispocl && T == Float16 && !(f in [OpenCL.rint, OpenCL.rsqrt]) + broken = ispocl && T == Float16 && (f == OpenCL.logb) @test call_on_device(f, x) isa Real broken = broken # Just check it doesn't error end broken = ispocl && T == Float16 @@ -157,7 +155,7 @@ end ] x = rand(T) y = rand(T) - broken = ispocl && T == Float16 && !(f in [OpenCL.maxmag, OpenCL.minmag]) + broken = ispocl && T == Float16 && (f in [OpenCL.nextafter, OpenCL.powr]) @test call_on_device(f, x, y) isa Real broken = broken # Just check it doesn't error end broken = ispocl && T == Float16 From 5416363bbd4f894283881237826a90d3544b6486 Mon Sep 17 00:00:00 2001 From: Michal Babej Date: Thu, 5 Mar 2026 17:41:47 +0200 Subject: [PATCH 2/2] temporarily switch PoCL repo to review --- .github/workflows/Test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Test.yml b/.github/workflows/Test.yml index e7b28f20..daff12b5 100644 --- a/.github/workflows/Test.yml +++ b/.github/workflows/Test.yml @@ -60,7 +60,8 @@ jobs: if: ${{ matrix.pocl == 'local' }} uses: actions/checkout@v6 with: - repository: pocl/pocl + repository: franz/pocl + ref: fixes path: pocl - name: Install system dependencies