Unexpected disabling of quitting on a modified file

[cldwalker]

While QAing LightTable/LightTable#1964 I ran into a behavior that quitting doesn't prompt to save on a modified file. I was surprised to discover that Reminisce explicitly disables this behavior. I don't think this behavior conflicts with anything in Reminisce i.e. :app object for :close trigger. Any objection if we remove it? Happy to open a PR for it

[MikeInnes]

The reason I got rid of that behaviour was essentially that it's not necessary with Reminisce enabled. That popup tells you that you're going to lose your changes if you close, when in fact the plugin will open the files with the content and dirty state preserved exactly as you left them. This actually reflects the behaviour of Sublime as well (although Sublime still confirms for transient/unsaved files, I think).

I'm not particularly adamant about it, so if you think it's best to go back to the default behaviour I'll happily take a PR. An alternative might be to make the modified behaviour clearer in the readme along with instructions for re-enabling confirmations.

[cldwalker]

I'm not particularly adamant about it, so if you think it's best to go back to the default behaviour I'll happily take a PR. An alternative might be to make the modified behaviour clearer in the readme along with instructions for re-enabling confirmations.

I'm not too adamant either. Perhaps we can leave this open for awhile and see if others find this unexpected or causes unexpected issues upstream.