helix.jl and fbp_helix_stack.jl#15
Conversation
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 29.97% 29.51% -0.46%
==========================================
Files 9 9
Lines 337 332 -5
==========================================
- Hits 101 98 -3
+ Misses 236 234 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| varargin.window = " " | ||
| varargin.short = true | ||
| varargin.chat = false | ||
| arg = vararg_pair(arg, varargin) |
There was a problem hiding this comment.
always use julia named keyword arguments with default values for options, not varargin.
follow the examples in other julia code like here:
https://github.com/JeffFessler/Sinograms.jl/blob/main/src/fbp2.jl
|
|
||
| nz = ig.nz; | ||
| ## 2d version of image geometry | ||
| ig = image_geom("nx", ig.nx, "dx", ig.dx, "offset_x", ig.offset_x, "ny", ig.ny, "dy", ig.dy, "offset_y", ig.offset_y,"mask", ig.mask_or) |
There was a problem hiding this comment.
see ImageGeoms.jl documentation for usage
| function args() | ||
|
|
||
| function streq(cg) | ||
| return cg == "test" | ||
| end | ||
|
|
||
| ##if streq(cg, 'test') | ||
| ## run helix_example | ||
| ##return | ||
| ##end | ||
|
|
There was a problem hiding this comment.
can cut all this.
but you do need an example
| return sino, orbits, used | ||
| end | ||
|
|
||
| function rebin_helix_scale(dfs, dsd, ss, tt) |
There was a problem hiding this comment.
use scalars s, t here, then use broadcast above.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 24 24
Lines 828 828
=======================================
Hits 825 825
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Initial commit, commenting and styling still left to do