AbstractUnitRange for BitArray/BitVector indexing#41810
Conversation
|
Can you also share more information about this change? For example, what was wrong with the previous status. The code change itself doesn't explain the background very well. It's also a good practice to have associated test cases with every non-trivial functionality change. I also see that you just opened the other two similar PR #41805, #41807 and #41809. The idea behind those changes are also uncleared to me. |
|
The impetus for the series of PRs stems from Basically if we have more |
|
For that, I don't have any objection. But please follow the previous PR #39896 as an example, prepare for more explanation and sufficient test cases so that when someone with privilege jumps in, he doesn't need to ask you to do these and we don't need to wait for one more round of review. |
|
Thanks @johnnychen94 . I just haven't had time to write it up just yet and mainly focusing on that |
Several methods could be generalized to work with
AbstractUnitRangerather than justUnitRange. There are now severalAbstractUnitRangesubtypes:This pull request adapts several methods to work on
BitArray/BitVectorandAbstractUnitRange.