improve error when broadcast failed due to axistype#45922
Merged
IanButterworth merged 5 commits intoFeb 5, 2024
Conversation
jishnub
reviewed
Jul 4, 2022
jishnub
reviewed
Jul 4, 2022
Moelf
force-pushed
the
helpful_error_broadcast_mix_axis
branch
from
e83bce1 to
4110374
Compare
N5N3
reviewed
Jul 8, 2022
Member
|
Is this good to go? |
Member
|
I'm not sure if it's a good idea to remove "broadcast" in the error message. |
vtjnash
force-pushed
the
helpful_error_broadcast_mix_axis
branch
from
f29854b to
5cd8e8b
Compare
vtjnash
reviewed
Feb 4, 2024
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
oscardssmith
removed
the
merge me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #45921