Skip to content

fix(join): declare loop-spawned closure locals to avoid soft-scope race #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krynju merged 1 commit into from
May 24, 2026
+7 −2
Merged

fix(join): declare loop-spawned closure locals to avoid soft-scope race #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/operations/join_interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ function _join(

process_one_chunk =
(type, l, r, cmp_l, cmp_r, other_r, lookup, r_sorted, l_sorted, r_unique) -> begin
# Variables below MUST be `local`: identifiers `inner_l`, `inner_r`, `outer_l`
# are also assigned in the enclosing `_join` body, so Julia's soft-scope rules
# would otherwise capture them by reference. Multiple `Dagger.@spawn`ed
# invocations of this closure would then race on the same binding cells.
local inner_l, inner_r, outer_l
inner_l, inner_r = match_inner_indices(
l, r, cmp_l, cmp_r, lookup, r_sorted, l_sorted, r_unique
)
Expand Down
4 changes: 2 additions & 2 deletions test/table.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ using OnlineStats
@test isequal(lj1u, lj7)
@test isequal(lj1, lj8)
@test isequal(lj1, lj9)
# @test isequal(lj1, lj10)
@test isequal(lj1, lj10)

ij1 = innerjoin(d1, d2, on=on)
ij1u = innerjoin(d1, unique(d2, r_colsymbols), on=on)
Expand All @@ -557,7 +557,7 @@ using OnlineStats
@test isequal(ij1u, ij7)
@test isequal(ij1, ij8)
@test isequal(ij1, ij9)
# @test isequal(ij1, ij10)
@test isequal(ij1, ij10)
@test isequal(ij1, ij11)
end
end
Expand Down
Loading