Fix JET errors around matching methods for lock(...) and unlock(...)#40
Closed
DilumAluthge wants to merge 1 commit into
Closed
Fix JET errors around matching methods for lock(...) and unlock(...)#40DilumAluthge wants to merge 1 commit into
lock(...) and unlock(...)#40DilumAluthge wants to merge 1 commit into
Conversation
….)` (#167) This is a forward-port of JuliaLang/Distributed.jl#167 (JuliaLang/Distributed.jl@9f6459f). ``` ┌ put_ref(rid::Distributed.RRID, caller::Int64, args::WeakRef) @ Distributed /workpath/Distributed.jl/src/remotecall.jl:709 │ no matching method found `lock(::Nothing)` (1/2 union split): Distributed.lock((rv::Distributed.RemoteValue).synctake::Union{Nothing, ReentrantLock}) └──────────────────── ``` ``` ┌ put_ref(rid::Distributed.RRID, caller::Int64, args::WeakRef) @ Distributed /workpath/Distributed.jl/src/remotecall.jl:710 │ no matching method found `unlock(::Nothing)` (1/2 union split): Distributed.unlock((rv::Distributed.RemoteValue).synctake::Union{Nothing, ReentrantLock}) ││││││││││││││└──────────────────── ``` ``` ┌ take_ref(rid::Any, caller::Any, args::Vararg{Any}) @ Distributed /workpath/Distributed.jl/src/remotecall.jl:734 │ no matching method found `lock(::Nothing)` (1/2 union split): Distributed.lock((rv::Distributed.RemoteValue).synctake::Union{Nothing, ReentrantLock}) └──────────────────── ``` ``` ┌ take_ref(rid::Any, caller::Any, args::Vararg{Any}) @ Distributed /workpath/Distributed.jl/src/remotecall.jl:742 │ no matching method found `unlock(::Nothing)` (1/2 union split): Distributed.unlock((rv::Distributed.RemoteValue).synctake::Union{Nothing, ReentrantLock}) └──────────────────── ``` ``` ┌ (::Distributed.var"#handle_msg##2#handle_msg##3"{Distributed.CallMsg{…}, Distributed.MsgHeader, Base.PipeEndpoint})() @ Distributed /workpath/Distributed.jl/src/process_messages.jl:292 │ no matching method found `unlock(::Nothing)` (1/2 union split): Distributed.unlock(((v::Distributed.SyncTake).rv::Distributed.RemoteValue).synctake::Union{Nothing, ReentrantLock}) └──────────────────── ``` (cherry picked from commit 01027d14d994da11b8962d9a20a2f5a6888dec5f) (cherry picked from commit 9f6459f83f08e2ef147d102afc1ea5d6d8ab1ec1)
DilumAluthge
changed the title
lock(...) and unlock(...) (#167)lock(...) and unlock(...)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 11 11
Lines 2086 2086
=======================================
Hits 1823 1823
Misses 263 263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a forward-port of JuliaLang/Distributed.jl#167 (JuliaLang/Distributed.jl@9f6459f).
(cherry picked from commit 9f6459f83f08e2ef147d102afc1ea5d6d8ab1ec1)