[BUGFIX] disable usless tests, adjust type hint for PhphStan in TtContentRepository

Author: DavidBruchmann

Classes/Domain/Repository/TtContentRepository.php

@@ -66,7 +66,7 @@ public function __construct()
      * @todo: move this in a repository
      *
      * @param string $shortcutItem The single page to be used as the tree root
-     * @param-out array $collectedItems The collected item data rows ordered by parent position, column position and sorting // array<int, array<non-empty-string, mixed>>
+     * @param-out array $collectedItems The collected item data rows ordered by parent position, column position and sorting
      * @param int $recursive The number of levels for the recursion
      * @param int $parentUid uid of the referencing tt_content record
      * @param int $language sys_language_uid of the referencing tt_content record

Tests/Functional/ContainerExtensionAvailabilityTest.php

@@ -75,7 +75,7 @@ public function containerExtensionIsLoaded(): void
             );
         }
 
-        self::assertTrue($isLoaded, 'Container extension should be loaded');
+        // self::assertTrue($isLoaded, 'Container extension should be loaded');
     }
 
     #[Test]

Tests/Functional/ContainerExtensionCompatibilityTest.php

@@ -272,7 +272,7 @@ public function pasteOperationWorksInContainerElements(): void
             self::fail('Container configuration cannot be created: ' . $e->getMessage());
         }
 
-        self::assertTrue(true, 'Container paste operation test completed');
+        // self::assertTrue(true, 'Container paste operation test completed');
     }
 
     #[Test]
@@ -291,7 +291,7 @@ public function containerParentParameterHandlingAcrossVersions(): void
         self::assertTrue(class_exists('B13\\Container\\Tca\\Registry'));
         // self::assertTrue(class_exists('B13\\Container\\Tca\\ContainerConfiguration'));
 
-        self::assertTrue(true, 'Container parameter handling test completed');
+        // self::assertTrue(true, 'Container parameter handling test completed');
     }
 
     /*

Tests/Functional/ShortcutPreviewRendererCompatibilityTest.php

@@ -64,8 +64,8 @@ private function createTestData(): void
             [
                 'uid' => 1,
                 'pid' => 1,
-                'tstamp' => 1577836800,
-                'crdate' => 1577836800,
+                // 'tstamp' => 1577836800,
+                // 'crdate' => 1577836800,
                 'deleted' => 0,
                 'hidden' => 0,
                 'CType' => 'text',
@@ -78,8 +78,8 @@ private function createTestData(): void
             [
                 'uid' => 2,
                 'pid' => 1,
-                'tstamp' => 1577836800,
-                'crdate' => 1577836800,
+                // 'tstamp' => 1577836800,
+                // 'crdate' => 1577836800,
                 'deleted' => 0,
                 'hidden' => 0,
                 'CType' => 'shortcut',
@@ -147,7 +147,7 @@ public function rendererHandlesVersionSpecificRecordMethods(): void
 
             // Test the actual methods that work
             $array = $record->toArray();
-            self::assertIsArray($array);
+            // self::assertIsArray($array);
             self::assertEquals(1, $array['uid']);
 
             // Test individual methods
@@ -184,7 +184,7 @@ public function getDataRowMethodHandlesVersionDifferences(): void
                 't3ver_oid' => 0,
                 't3ver_state' => 0,
                 't3ver_stage' => 0,
-                'crdate' => 0,
+                // 'crdate' => 0,
                 'header' => 'Test Record',
             ];
 
@@ -214,7 +214,7 @@ public function getDataRowMethodHandlesVersionDifferences(): void
                 't3ver_oid' => 0,
                 't3ver_state' => 0,
                 't3ver_stage' => 0,
-                'crdate' => 0,
+                // 'crdate' => 0,
                 'header' => 'Test Record',
             ];
 
@@ -261,7 +261,7 @@ public function getContentRecordObjMethodWorksInV14(): void
                 't3ver_oid' => 0,
                 't3ver_state' => 0,
                 't3ver_stage' => 0,
-                'crdate' => 0,
+                // 'crdate' => 0,
                 'header' => 'Test Content',
             ];
 
@@ -298,7 +298,7 @@ public function rendererCanHandleGridColumnItemsAcrossVersions(): void
             't3ver_oid' => 0,
             't3ver_state' => 0,
             't3ver_stage' => 0,
-            'crdate' => 0,
+            // 'crdate' => 0,
             'header' => 'Reference Element',
             'records' => '1',
         ];
@@ -310,7 +310,7 @@ public function rendererCanHandleGridColumnItemsAcrossVersions(): void
 
             // Verify the record has the expected methods
             self::assertTrue(method_exists($record, 'getRow'));
-            self::assertTrue(method_exists($record, 'getUid'));
+            // self::assertTrue(method_exists($record, 'getUid'));
 
             $row = $record->getRow();
             self::assertEquals('shortcut', $row['CType']);
@@ -361,19 +361,19 @@ public function rendererHandlesRecordFactoryAvailability(): void
                 't3ver_state' => 0,
                 't3ver_stage' => 0,
                 't3ver_oid' => 0,
-                'crdate' => 0,
+                // 'crdate' => 0,
             ];
 
             $record = $recordFactory->createFromDatabaseRow('tt_content', $testData);
 
-            self::assertInstanceOf(RecordInterface::class, $record);
+            // self::assertInstanceOf(RecordInterface::class, $record);
 
         } else {
             // In v13 and below, RecordFactory might not exist or behave differently
             if (class_exists(RecordFactory::class)) {
-                self::assertTrue(true, 'RecordFactory exists but behavior may differ in v13');
+                // self::assertTrue(true, 'RecordFactory exists but behavior may differ in v13');
             } else {
-                self::assertTrue(true, 'RecordFactory not available in TYPO3 v13, which is expected');
+                // self::assertTrue(true, 'RecordFactory not available in TYPO3 v13, which is expected');
             }
         }
     }
@@ -422,14 +422,14 @@ public function rendererHandlesExtensionConfigurationCorrectly(): void
         self::assertIsArray($config);
 
         // Test that the renderer can handle missing configuration gracefully
-        self::assertTrue(true, 'Renderer should handle extension configuration without errors');
+        // self::assertTrue(true, 'Renderer should handle extension configuration without errors');
     }
 
     #[Test]
     public function rendererInheritsFromStandardContentPreviewRenderer(): void
     {
         // Verify inheritance chain
-        self::assertInstanceOf(StandardContentPreviewRenderer::class, $this->renderer);
+        // self::assertInstanceOf(StandardContentPreviewRenderer::class, $this->renderer);
 
         // Test that parent methods are available
         $reflection = new \ReflectionClass(StandardContentPreviewRenderer::class);

Tests/Functional/VersionSpecificCompatibilityTest.php

@@ -286,7 +286,7 @@ public function iconApiIsVersionCompatible(): void
 
             // Test icon identifier usage pattern
             $iconIdentifier = 'actions-document-paste-after';
-            self::assertIsString($iconIdentifier);
+            // self::assertIsString($iconIdentifier);
 
             // The extension uses standard TYPO3 icon identifiers which should be stable
             $standardIcons = [

Tests/Unit/DeprecatedApiDetectionTest.php

@@ -161,7 +161,7 @@ public function extensionHandlesTypo3VersionDifferences(): void
 
         // Version handling is optional but good practice
         if ($hasVersionHandling) {
-            self::assertTrue($hasVersionHandling, 'Extension has version-specific handling');
+            // self::assertTrue($hasVersionHandling, 'Extension has version-specific handling');
         }
     }
 
@@ -236,9 +236,7 @@ public function shortcutPreviewRendererHandlesVersionSpecificApis(): void
 
         // Check that RecordFactory is used conditionally
         $hasRecordFactoryUsage = str_contains($content, 'RecordFactory');
-        if ($hasRecordFactoryUsage) {
-            self::assertTrue($hasRecordFactoryUsage, 'RecordFactory usage should be version-aware');
-        }
+        self::assertTrue($hasRecordFactoryUsage, 'RecordFactory usage should be version-aware');
 
         // Verify no hardcoded version assumptions
         $problematicPatterns = [