[1.40.3] Swapping characteristics fails to load custom difficulty labels until the map is selected again

[TheBlackParrot]

Noticed this the other day out of the blue, confirmed on a lightly modded setup with the most recent version of SongCore on 1.40.3.
_latest.log

Select a map with multiple characteristics that uses difficulty labels (for example: https://beatsaver.com/maps/3dc0c), swap the active characteristic, and difficulty labels swap to defaults. Selecting a different map then going back to the same map brings the custom labels back.

[codeman4033]

Same on 1.40.4

[codeman4033]

And 1.40.6

[ibillingsley]

This is still an issue but only after playing the map.

The following fixes it, but may not be the best way to do it:

diff --git a/source/SongCore/Patches/SongDataMenuPatches.cs b/source/SongCore/Patches/SongDataMenuPatches.cs
index 99d9b73..6f8075f 100644
--- a/source/SongCore/Patches/SongDataMenuPatches.cs
+++ b/source/SongCore/Patches/SongDataMenuPatches.cs
@@ -55,10 +55,10 @@ namespace SongCore.Patches
             {
                 _songData = _standardLevelDetailViewController.beatmapLevel != null ? Collections.GetCustomLevelSongData(_standardLevelDetailViewController.beatmapLevel.levelID) : null;
                 _characteristicDifficultyLabels.Clear();
+                GetDifficultyLabels();
             }
         }
 
-        [AffinityPatch(typeof(BeatmapCharacteristicSegmentedControlController), nameof(BeatmapCharacteristicSegmentedControlController.SetData))]
         private void GetDifficultyLabels()
         {
             if (_songData == null)

I figured since that is the only place where _songData is set, we may as well populate the difficulty labels dictionary immediately.

[Meivyn]

This is still an issue because the fix on the dev branch hasn't been released yet.

[ibillingsley]

I can still reproduce on the dev branch (but only after playing/practicing the map), I've been using it.
The patch I posted is for the dev branch.

[Meivyn]

What are the exact reproduction steps?

[ibillingsley]

1. Select a map with custom difficulty labels and multiple characteristics (e.g. https://beatsaver.com/maps/47948)
2. Click Play (or Practice -> Play)
3. Go back to menu (press escape or pause -> menu)
4. Select a different characteristic (Standard/Lawless)

[Meivyn]

That hopefully will fix it, I'm really tired of fixing these patches over and over again.
Your solution would indeed have solved this specific issue, but it would bring back another issue that I had to fix in the past.

[ibillingsley]

Now getting a null pointer exception when selecting certain maps such as https://beatsaver.com/maps/48951

System.NullReferenceException: Object reference not set to an instance of an object
  at SongCore.Patches.SongDataMenuPatches.SetCosmeticCharacteristic (BeatmapCharacteristicSO selectedBeatmapCharacteristic) [0x00000] in SongCore\source\SongCore\Patches\SongDataMenuPatches.cs:156 
  at _SetData_SetCosmeticCharacteristic_0de323f4_af09_45ed_bb18_5c310035ba58.Patch (BeatmapCharacteristicSO selectedBeatmapCharacteristic) [0x0000a] in <3007224f35a3472db7802d6c1626b790>:0 
  at (wrapper dynamic-method) BeatmapCharacteristicSegmentedControlController.DMD<BeatmapCharacteristicSegmentedControlController::SetData>(BeatmapCharacteristicSegmentedControlController,System.Collections.Generic.IEnumerable`1<BeatmapCharacteristicSO>,BeatmapCharacteristicSO,System.Collections.Generic.HashSet`1<BeatmapCharacteristicSO>)
  at StandardLevelDetailView.SetContent (BeatmapLevel level, BeatmapDifficultyMask allowedBeatmapDifficultyMask, System.Collections.Generic.HashSet`1[T] notAllowedCharacteristics, BeatmapDifficulty defaultDifficulty, BeatmapCharacteristicSO defaultBeatmapCharacteristic, PlayerData playerData) [0x0009f] in <88270a2ad1c34c92afe924528c900003>:0 
  at StandardLevelDetailViewController.ShowOwnedContent () [0x00043] in <88270a2ad1c34c92afe924528c900003>:0 
  at StandardLevelDetailViewController.<RefreshAvailabilityIfNeeded>b__58_0 (System.Threading.CancellationToken token) [0x0009d] in <88270a2ad1c34c92afe924528c900003>:0 
  at (wrapper dynamic-method) StandardLevelDetailViewController+<ShowLoadingAndDoSomething>d__61.DMD<StandardLevelDetailViewController+<ShowLoadingAndDoSomething>d__61::MoveNext>(StandardLevelDetailViewController/<ShowLoadingAndDoSomething>d__61&)

SongCore/source/SongCore/Patches/SongDataMenuPatches.cs

Lines 154 to 157 in 3174120

	private void SetCosmeticCharacteristic(BeatmapCharacteristicSO selectedBeatmapCharacteristic)
	{
	if (_songData == null || _songData._characteristicDetails.Length == 0 || !_config.DisplayCustomCharacteristics)
	{

Changing _songData._characteristicDetails.Length == 0 back to _songData._characteristicDetails == null fixes it although I'm not sure why it's null in the first place.

Also sorry for the frustration, I appreciate all the work you do.