Performance profiler for any MPC protocol

[survived]

Benchmarking performance of the protocol is one of the essential steps of development cycle. Until now, we don't have any "generic" tool for profiling performance of MPC protocols. Instead, MPC implementations have their own profiling utilities, e.g. cggmp24::progress::Tracer.

Latest v0.5.0-alpha.1 release restructures round_based::Mpc trait. One could implement a PerfProfiler that wraps and implements round_based::Mpc. By intercepting calls to MpcExecution::{send, complete}, PerfProfiler could measure exactly how long takes each round (pure computations) and how much time we spend on sending/receiving messages (i.e. on I/O).

At the end of the protocol execution, profiler would provide stats. Similarly to cggmp24::progress::PerfReport, stats should implement Display, so we can print them to the terminal. It would be beneficial to have some sort of statistical analysis: provided reports from several executions, find the means per each round, deviation, p50/p75/p90.

[ZiaCheemaGit]

@survived I applied for Advanced Threshold Key Management mentorship on LFX. I think this is a good chance to understand the project. I have cloned the repo and build it successfully.
I have not fully looked into sim but was wondering will it be a sufficient to test the PerfProfiler in simultion by examples/random-generation-protocol.

[ZiaCheemaGit]

Moreover in contributing.md I only found one requirement that commits should be signed. Are there any other prereqs I should know before creating a PR.
And is it just me or is the discord link actually broken?(Both the one in contributing.md and also in docs)

[ZiaCheemaGit]

What I understood?
What user currently does

mpc = mpc (MPC trait)
mpc.add_round(round1);
mpc.add_round(round2);

exec = mpc.finish_setup();

output = exec.complete(round2).await;

PerfProfiler will enable user to optionally do the same like this:

prof = PerfProfiler (Wrapper)
prof.add_round(round1);
prof.add_round(round2);

exec = prof.finish_setup();

output = exec.complete(round2).await;
prof.display() 

Thats it right?

[ZiaCheemaGit]

Addressed by PR #22

[survived]

Hey @ZiaCheemaGit, sorry for long response.

Yes I think your understanding is right, and what you saw in PR goes in the same direction.

Moreover in contributing.md I only found one requirement that commits should be signed. Are there any other prereqs I should know before creating a PR. And is it just me or is the discord link actually broken?(Both the one in contributing.md and also in docs)

It does work for me, but you're not the first one who says that it's broken. I'm not sure what to do there. Does this link work for you: https://discord.com/invite/hyperledger? If it does, then you can find #lockness-contribute channel.