python: black + ruff

adsharma · adsharma · commit 447196919b19 · 2026-04-22T18:20:22.000-07:00
diff --git a/pyproject.toml b/pyproject.toml
@@ -113,6 +113,7 @@ ignore = [
 
 [tool.ruff.lint.per-file-ignores]
 "test/**/*.py" = ["D100", "D102", "D103", "E501", "F841", "TCH002"]
+"src_py/__init__.py" = ["RUF067"]
 "src_py/torch_geo*.py" = ["E501", "FBT001"]
 "src_py/_lbug_capi.py" = ["E501", "RUF012", "FBT001", "EM101"]
 
diff --git a/src_py/__init__.py b/src_py/__init__.py
@@ -57,12 +57,12 @@
 if _repo_build_pkg_dir.is_dir():
     __path__.append(str(_repo_build_pkg_dir))
 
-from .async_connection import AsyncConnection
-from .connection import Connection
-from .database import Database
-from .prepared_statement import PreparedStatement
-from .query_result import QueryResult
-from .types import Type
+from .async_connection import AsyncConnection  # noqa: E402
+from .connection import Connection  # noqa: E402
+from .database import Database  # noqa: E402
+from .prepared_statement import PreparedStatement  # noqa: E402
+from .query_result import QueryResult  # noqa: E402
+from .types import Type  # noqa: E402
 
 
 def __getattr__(name: str) -> str | int:
diff --git a/src_py/_lbug_capi.py b/src_py/_lbug_capi.py
@@ -1041,7 +1041,7 @@ def bind_parameters(self, parameters: dict[str, Any]) -> None:
         for key, value in parameters.items():
             if not isinstance(key, str):
                 msg = f"Parameter name must be of type string but got {type(key)}"
-                raise RuntimeError(msg)
+                raise TypeError(msg)
             key_b = key.encode("utf-8")
             value_ptr = _value_from_python(value)
             try:
diff --git a/src_py/connection.py b/src_py/connection.py
@@ -145,7 +145,7 @@ def _normalize_parameters_for_capi(
         for key, value in list(normalized_params.items()):
             if not isinstance(key, str):
                 msg = f"Parameter name must be of type string but got {type(key)}"
-                raise RuntimeError(msg)
+                raise TypeError(msg)
 
             if isinstance(value, (bytes, bytearray, memoryview)):
                 binary = bytes(value)
@@ -157,11 +157,7 @@ def _normalize_parameters_for_capi(
 
     def _is_python_scan_object(self, value: Any) -> bool:
         module_name = type(value).__module__
-        return (
-            module_name.startswith("pandas")
-            or module_name.startswith("polars")
-            or module_name.startswith("pyarrow")
-        )
+        return module_name.startswith(("pandas", "polars", "pyarrow"))
 
     def _has_scan_pattern(self, query: str) -> bool:
         stripped = query.lstrip()
@@ -283,11 +279,7 @@ def _maybe_raise_scan_unsupported_object(self, query: str) -> None:
 
         value = scope[var_name]
         module_name = type(value).__module__
-        if (
-            module_name.startswith("pandas")
-            or module_name.startswith("polars")
-            or module_name.startswith("pyarrow")
-        ):
+        if module_name.startswith(("pandas", "polars", "pyarrow")):
             return
 
         msg = (
diff --git a/src_py/database.py b/src_py/database.py
@@ -2,7 +2,7 @@
 
 import os
 from pathlib import Path
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, ClassVar
 from weakref import WeakSet
 
 from . import _lbug_capi as _lbug
@@ -35,7 +35,7 @@
 class Database:
     """Lbug database instance."""
 
-    _VALID_BACKENDS = {"auto", "capi", "pybind"}
+    _VALID_BACKENDS: ClassVar[set[str]] = {"auto", "capi", "pybind"}
 
     def __init__(
         self,
diff --git a/src_py/query_result.py b/src_py/query_result.py
@@ -171,16 +171,16 @@ def get_as_df(self) -> pd.DataFrame:
         """
         Get the query result as a Pandas DataFrame.
 
-        See Also
-        --------
-        get_as_pl : Get the query result as a Polars DataFrame.
-        get_as_arrow : Get the query result as a PyArrow Table.
-
         Returns
         -------
         pandas.DataFrame
             Query result as a Pandas DataFrame.
 
+        See Also
+        --------
+        get_as_pl : Get the query result as a Polars DataFrame.
+        get_as_arrow : Get the query result as a PyArrow Table.
+
         """
         self.check_for_query_result_close()
 
@@ -190,15 +190,15 @@ def get_as_pl(self) -> pl.DataFrame:
         """
         Get the query result as a Polars DataFrame.
 
-        See Also
-        --------
-        get_as_df : Get the query result as a Pandas DataFrame.
-        get_as_arrow : Get the query result as a PyArrow Table.
-
         Returns
         -------
         polars.DataFrame
             Query result as a Polars DataFrame.
+
+        See Also
+        --------
+        get_as_df : Get the query result as a Pandas DataFrame.
+        get_as_arrow : Get the query result as a PyArrow Table.
         """
         import polars as pl
 
@@ -229,15 +229,15 @@ def get_as_arrow(
         fallbackExtensionTypes : bool
             Avoid using Arrow extension types for compatibility with Polars
 
-        See Also
-        --------
-        get_as_pl : Get the query result as a Polars DataFrame.
-        get_as_df : Get the query result as a Pandas DataFrame.
-
         Returns
         -------
         pyarrow.Table
             Query result as a PyArrow Table.
+
+        See Also
+        --------
+        get_as_pl : Get the query result as a Polars DataFrame.
+        get_as_df : Get the query result as a Pandas DataFrame.
         """
         self.check_for_query_result_close()
 
diff --git a/test/test_arrow.py b/test/test_arrow.py
@@ -7,13 +7,13 @@
 from uuid import UUID
 
 import ground_truth
+import ladybug as lb
 import polars as pl
 import pyarrow as pa
 import pytest
 import pytz
-import ladybug as lb
-from pandas import Timestamp
 from ladybug.constants import DST, ID, LABEL, NODES, SRC
+from pandas import Timestamp
 from type_aliases import ConnDB
 
 _expected_dtypes = {
diff --git a/test/test_async_connection.py b/test/test_async_connection.py
@@ -1,9 +1,9 @@
 import asyncio
 import time
 
+import ladybug as lb
 import pyarrow as pa
 import pytest
-import ladybug as lb
 
 
 @pytest.mark.asyncio
diff --git a/test/test_connection.py b/test/test_connection.py
@@ -4,8 +4,8 @@
 import time
 from typing import TYPE_CHECKING
 
-import pytest
 import ladybug as lb
+import pytest
 from type_aliases import ConnDB
 
 if TYPE_CHECKING:
diff --git a/test/test_database.py b/test/test_database.py
@@ -5,8 +5,8 @@
 from pathlib import Path
 from textwrap import dedent
 
-import pytest
 import ladybug as lb
+import pytest
 from conftest import get_db_file_path
 
 
diff --git a/test/test_datatype.py b/test/test_datatype.py
@@ -5,6 +5,7 @@
 from decimal import Decimal
 from uuid import UUID
 
+import pytest
 import pytz
 from ladybug.constants import DST, ID, LABEL, NODES, RELS, SRC
 from type_aliases import ConnDB
@@ -294,7 +295,7 @@ def test_node(conn_db_readonly: ConnDB) -> None:
     assert n["fName"] == "Alice"
     assert n["gender"] == 1
     assert n["isStudent"] is True
-    assert n["eyeSight"] == 5.0
+    assert n["eyeSight"] == pytest.approx(5.0)
     assert n["birthdate"] == datetime.date(1900, 1, 1)
     assert n["registerTime"] == datetime.datetime(2011, 8, 20, 11, 25, 30)
     assert n["lastJobDuration"] == datetime.timedelta(days=1082, seconds=46920)
@@ -413,8 +414,8 @@ def test_large_array(conn_db_readwrite: ConnDB) -> None:
 
     sample = conn.execute("MATCH (u:_User {id: 42}) RETURN u.embedding").get_next()[0]
     assert len(sample) == 1670
-    assert sample[0] == 42.0
-    assert sample[1669] == 42.0 + 1669.0 / 1000.0
+    assert sample[0] == pytest.approx(42.0)
+    assert sample[1669] == pytest.approx(42.0 + 1669.0 / 1000.0)
 
 
 def test_json(conn_db_readonly: ConnDB) -> None:
diff --git a/test/test_df.py b/test/test_df.py
@@ -6,10 +6,10 @@
 from typing import Any
 from uuid import UUID
 
-import pytz
 import ladybug as lb
-from pandas import Timedelta, Timestamp
+import pytz
 from ladybug.constants import DST, ID, LABEL, NODES, RELS, SRC
+from pandas import Timedelta, Timestamp
 from type_aliases import ConnDB
 
 
diff --git a/test/test_exception.py b/test/test_exception.py
@@ -1,7 +1,7 @@
 from __future__ import annotations
 
-import pytest
 import ladybug as lb
+import pytest
 from type_aliases import ConnDB
 
 
diff --git a/test/test_fsm.py b/test/test_fsm.py
@@ -1,7 +1,7 @@
 from pathlib import Path
 
-import pytest
 import ladybug as lb
+import pytest
 from conftest import get_db_file_path
 from test_helper import LBUG_ROOT
 
diff --git a/test/test_mvcc_bank.py b/test/test_mvcc_bank.py
@@ -32,8 +32,8 @@
 from dataclasses import dataclass, field
 from typing import TYPE_CHECKING
 
-import pytest
 import ladybug as lb
+import pytest
 
 if TYPE_CHECKING:
     from pathlib import Path
diff --git a/test/test_networkx.py b/test/test_networkx.py
@@ -3,8 +3,8 @@
 import datetime
 from typing import Any
 
-from pandas import Timedelta, Timestamp
 from ladybug.constants import LABEL
+from pandas import Timedelta, Timestamp
 from type_aliases import ConnDB
 
 
diff --git a/test/test_query_result.py b/test/test_query_result.py
@@ -46,9 +46,7 @@ def test_multiple_query_results(conn_db_readonly: ConnDB) -> None:
     conn, _ = conn_db_readonly
     results = conn.execute("RETURN 1; RETURN 2; RETURN 3;")
     assert len(results) == 3
-    i = 1
-    for result in results:
+    for i, result in enumerate(results, start=1):
         assert result.get_num_tuples() == 1
         assert result.has_next()
         assert result.get_next() == [i]
-        i += 1
