bug: artifact pattern mismatch breaks gitops-update for single-app repos

[bedatty]

Description

There is a naming mismatch between how build.yml uploads GitOps artifacts and how gitops-update.yml downloads them, causing gitops-update to fail for single-app (non-monorepo) repositories.

Root Cause

In build.yml, the artifact is uploaded with the name:

gitops-tags-${{ matrix.app.name }}

For single-app repos (no filter_paths), matrix.app.name resolves to the repository name (e.g., plugin-fees), so the artifact is named:

gitops-tags-plugin-fees

In gitops-update.yml, the download step uses a pattern-based match:

pattern: ${{ steps.setup.outputs.artifact_pattern }}

The default artifact_pattern is built as gitops-tags-${APP_NAME}-*, which resolves to:

gitops-tags-plugin-fees-*

The glob * requires at least one character after plugin-fees-, so it does not match gitops-tags-plugin-fees. The fallback to the legacy name gitops-tags also does not match.

Impact

• Affects all single-app repositories using build.yml + gitops-update.yml at v1.13.1
• The Validate artifacts exist step fails with: No artifacts directory found
• GitOps updates and ArgoCD syncs are completely blocked

Reproduction

• Repository: LerianStudio/plugin-fees
• Failed run: Build Pipeline #84

Suggested Fix

Either:

1. Change the upload name in build.yml to include a trailing separator for consistency with monorepo naming (e.g., gitops-tags-plugin-fees-root)
2. Change the default download pattern in gitops-update.yml to gitops-tags-${APP_NAME}* (without the - before *)
3. Change the download pattern to use an exact name match for single-app repos and pattern for monorepos

[bedatty]

https://github.com/LerianStudio/plugin-fees/blob/bb72796051ac676da7cca36d7b1a3fa1a0865167/.github/workflows/build.yml