Refactor validation error logging in Identities services for clarity and consistency

Author: tacxou

src/management/identities/abstract-identities.service.ts

@@ -46,17 +46,13 @@ export abstract class AbstractIdentitiesService extends AbstractServiceSchema {
     }
 
     if (error instanceof ValidationSchemaException) {
-      this.logger.warn(`${logPrefix} Validation schema error. ${JSON.stringify(error.getValidations())}`);
-      identity.additionalFields.validations = error.getValidations() as any;
-      // console.log('identity.state', identity.state)
-      if (identity.state === IdentityState.TO_CREATE) {
-        this.logger.warn(`${logPrefix} State set to TO_COMPLETE.`);
-        identity.state = IdentityState.TO_COMPLETE;
-        return identity;
-      } else {
-        this.logger.error(`${logPrefix} Validation schema error. ${JSON.stringify(error.getValidations())}`);
-        throw new ValidationSchemaException(error.getPayload());
-      }
+      this.logger.warn(`${logPrefix} Validation handleValidationError schema error. ${JSON.stringify(error.getValidations())}`);
+      identity.additionalFields.validations = error.getValidations();
+
+      this.logger.warn(`${logPrefix} State set to TO_COMPLETE.`);
+      identity.state = IdentityState.TO_COMPLETE;
+
+      return identity;
     } else {
       this.logger.error(`${logPrefix} Unhandled error: ${error.message}`);
       throw error; // Rethrow the original error if it's not one of the handled types.

src/management/identities/identities-crud.service.ts

@@ -37,7 +37,7 @@ export class IdentitiesCrudService extends AbstractIdentitiesService {
         throw new ValidationConfigException(error.getPayload());
       }
       if (error instanceof ValidationSchemaException) {
-        this.logger.warn(`${logPrefix} Validation schema error. ${JSON.stringify(error.getValidations())}`);
+        this.logger.warn(`${logPrefix} Validation create schema error. ${JSON.stringify(error.getValidations())}`);
         data.additionalFields.validations = error.getValidations();
         throw new ValidationSchemaException(error.getPayload());
       } else {
@@ -100,7 +100,7 @@ export class IdentitiesCrudService extends AbstractIdentitiesService {
         throw new ValidationConfigException(error.getPayload());
       }
       if (error instanceof ValidationSchemaException) {
-        this.logger.warn(`${logPrefix} Validation schema error. ${JSON.stringify(error.getValidations())}`);
+        this.logger.warn(`${logPrefix} Validation update schema error. ${JSON.stringify(error.getValidations())}`);
         update.additionalFields.validations = error.getValidations();
         throw new ValidationSchemaException(error.getPayload());
       } else {