Refactor logging in identities services to use structured logging and improve debug output

Author: tacxou

src/management/identities/abstract-identities.service.ts

@@ -116,6 +116,7 @@ export abstract class AbstractIdentitiesService extends AbstractServiceSchema {
     this.logger.debug(`Fingerprint updated for <${identity._id}>: ${fingerprint}`);
     return updated as unknown as ModifyResult<Query<T, T, any, T>>;
   }
+
   protected async previewFingerprint(identity: any): Promise<string> {
     const additionalFields = omit(identity.additionalFields, ['validations']);
     const data = JSON.stringify(
@@ -132,6 +133,7 @@ export abstract class AbstractIdentitiesService extends AbstractServiceSchema {
         ),
       ),
     );
+    console.log('datadata', data);
 
     const hash = createHash('sha256');
     hash.update(data);

src/management/identities/identities-upsert.service.ts

@@ -64,9 +64,10 @@ export class IdentitiesUpsertService extends AbstractIdentitiesService {
         ...crushedUpdate,
       }),
     );
+
     await this.checkFingerprint(filters, fingerprint);
 
-    console.log('insert', {
+    this.logger.verbose('identities upsert data: ' + JSON.stringify({
       $setOnInsert: {
         ...crushedSetOnInsert,
         // 'state': IdentityState.TO_CREATE,
@@ -76,7 +77,7 @@ export class IdentitiesUpsertService extends AbstractIdentitiesService {
         'additionalFields.objectClasses': data.additionalFields.objectClasses,
         lastSync: new Date(),
       },
-    });
+    }, null, 2));
 
     const upserted = await super.upsert(
       filters,

src/management/identities/validations/identities.validation.service.ts

@@ -24,7 +24,7 @@ export class IdentitiesValidationService implements OnApplicationBootstrap {
   public constructor() {
     ajvErrors(this.ajv);
     this.validateSchema = this.ajv.compile(validSchema);
-    this.logger = new Logger();
+    this.logger = new Logger(IdentitiesValidationService.name);
   }
 
   public onApplicationBootstrap(): void {
@@ -174,7 +174,7 @@ export class IdentitiesValidationService implements OnApplicationBootstrap {
       }
     }
 
-    console.log(data[key]);
+    this.logger.debug(`Additionalfields object validation: ${JSON.stringify(data[key])}`);
 
     const yupSchema = buildYup(schema, { noSortEdges: true });
     try {