Refactor countAll method in IdentitiesCrudService to enforce a maximum filter limit and update response structure in IdentitiesCrudController

Author: tacxou

src/management/identities/identities-crud.controller.ts

@@ -207,18 +207,22 @@ export class IdentitiesCrudController extends AbstractController {
       [key: string]: FilterSchema;
     },
     @SearchFilterOptions() searchFilterOptions: FilterOptions,
-  ): Promise<Response<number>> {
-    const filters = {}
-    for (const key in body) {
-      filters[key] = filterSchema(body[key]);
-      console.log('filters', key, body[key], filters[key]);
-    }
+  ): Promise<Response<{
+    statusCode: number;
+    data: {
+      [key: string]: number;
+    };
+  }>> {
+    const filters = Object.entries(body).reduce((acc, [key, value]) => {
+      acc[key] = filterSchema(value);
+      return acc;
+    }, {} as Record<string, FilterSchema>);
 
-    const totals = await this._service.countAll(filters, searchFilterOptions);
+    const data = await this._service.countAll(filters, searchFilterOptions);
 
     return res.status(HttpStatus.OK).json({
       statusCode: HttpStatus.OK,
-      data: totals,
+      data,
     });
   }
 

src/management/identities/identities-crud.service.ts

@@ -7,6 +7,8 @@ import { Identities } from '~/management/identities/_schemas/identities.schema';
 import { BadRequestException, HttpException } from '@nestjs/common';
 import { CountOptions } from 'mongodb';
 
+export const COUNT_ALL_MAX_ITERATIONS = 500;
+
 export class IdentitiesCrudService extends AbstractIdentitiesService {
   public async create<T extends AbstractSchema | Document>(
     data?: any,
@@ -138,8 +140,8 @@ export class IdentitiesCrudService extends AbstractIdentitiesService {
   public async countAll<T extends AbstractSchema | Document>(filters: {
     [key: string]: FilterQuery<T>;
   }, options?: (CountOptions & MongooseBaseQueryOptions<T>) | null) {
-    if (Object.keys(filters).length >= 5) {
-      throw new BadRequestException('Too many filters');
+    if (Object.keys(filters).length >= COUNT_ALL_MAX_ITERATIONS) {
+      throw new BadRequestException(`Too many filters (max: ${COUNT_ALL_MAX_ITERATIONS})`);
     }
 
     const entries = Object.entries(filters);