update lint

Author: Linktur

.gitignore

@@ -37,5 +37,6 @@ credentials
 *.retry
 .vault_pass
 ansible/group_vars/all.yml
+ansible/group_vars/*.bak
 ansible/inventory/*.pyc
 __pycache__/

ansible/.ansible-lint

@@ -0,0 +1,4 @@
+---
+skip_list:
+  - key-order
+  - var-naming

ansible/playbooks/deploy.yml

@@ -10,13 +10,11 @@
       register: deploy_local_group_vars
       delegate_to: localhost
       become: false
-      run_once: true
 
     - name: Load local vaulted variables when available
       ansible.builtin.include_vars:
         file: "{{ playbook_dir }}/../group_vars/all.yml"
       when: deploy_local_group_vars.stat.exists
-      run_once: true
 
   roles:
     - role: web_app

ansible/playbooks/site.yml

@@ -1,3 +1,6 @@
 ---
-- import_playbook: provision.yml
-- import_playbook: deploy.yml
+- name: Run Provision Playbook
+  import_playbook: provision.yml
+
+- name: Run Deploy Playbook
+  import_playbook: deploy.yml

ansible/roles/common/tasks/main.yml

@@ -21,9 +21,12 @@
     - name: Set timezone
       ansible.builtin.command: "timedatectl set-timezone {{ common_timezone }}"
       when: common_current_timezone.stdout != common_timezone
+      changed_when: true
   rescue:
     - name: Recover apt metadata after failed package preparation
-      ansible.builtin.command: apt-get update --fix-missing
+      ansible.builtin.apt:
+        update_cache: true
+        force_apt_get: true
       changed_when: false
 
     - name: Retry apt cache update after recovery

ansible/roles/docker/handlers/main.yml

@@ -1,5 +1,5 @@
 ---
-- name: restart docker
+- name: Restart docker
   ansible.builtin.service:
     name: docker
     state: restarted

ansible/roles/docker/tasks/main.yml

@@ -24,7 +24,7 @@
         url: "{{ docker_gpg_key_url }}"
         dest: "{{ docker_apt_keyring_file }}"
         mode: "0644"
-      notify: restart docker
+      notify: Restart docker
 
     - name: Add Docker apt repository
       ansible.builtin.apt_repository:
@@ -35,15 +35,15 @@
           {{ docker_apt_release }} stable
         state: present
         filename: docker
-      notify: restart docker
+      notify: Restart docker
 
     - name: Install Docker packages
       ansible.builtin.apt:
         name: "{{ docker_packages }}"
         state: present
         update_cache: true
         lock_timeout: 600
-      notify: restart docker
+      notify: Restart docker
   rescue:
     - name: Wait before retrying Docker apt metadata updates
       ansible.builtin.pause:

ansible/roles/web_app/handlers/main.yml

@@ -1,5 +1,5 @@
 ---
-- name: restart web application
+- name: Restart web application
   community.docker.docker_compose_v2:
     project_src: "{{ compose_project_dir }}"
     state: present

ansible/roles/web_app/tasks/wipe.yml

@@ -14,7 +14,6 @@
         state: absent
       when: web_app_compose_file.stat.exists
       become: true
-      ignore_errors: true
 
     - name: Optionally remove application image
       community.docker.docker_image:
@@ -23,29 +22,25 @@
         force_absent: true
       when: web_app_remove_image | bool
       become: true
-      ignore_errors: true
 
     - name: Remove legacy container with the same name
       community.docker.docker_container:
         name: "{{ app_name }}"
         state: absent
         force_kill: true
       become: true
-      ignore_errors: true
 
     - name: Remove docker-compose file
       ansible.builtin.file:
         path: "{{ compose_project_dir }}/docker-compose.yml"
         state: absent
       become: true
-      ignore_errors: true
 
     - name: Remove application directory
       ansible.builtin.file:
         path: "{{ compose_project_dir }}"
         state: absent
       become: true
-      ignore_errors: true
 
     - name: Confirm wipe completion
       ansible.builtin.debug: