test: improve SearchOperationsTest postgres coverage

Author: msmithstubbs

lib/logflare/logs/search_operations.ex

@@ -73,6 +73,8 @@ defmodule Logflare.Logs.SearchOperations do
     backend = postgres_backend(so)
 
     PostgresAdaptor.execute_query(backend, so.query, query_type: :search)
+  rescue
+    error -> {:error, error}
   end
 
   defp execute_backend_query(%SO{} = so) do

test/logflare/logs/search_operations_test.exs

@@ -3,6 +3,7 @@ defmodule Logflare.Logs.SearchOperationsTest do
 
   import Ecto.Query
   import Logflare.Utils.Guards
+  import Logflare.TestUtils
 
   alias Logflare.Backends
   alias Logflare.Backends.Adaptor.BigQueryAdaptor
@@ -197,11 +198,11 @@ defmodule Logflare.Logs.SearchOperationsTest do
   end
 
   describe "postgres chart aggregation" do
+    setup_single_tenant(backend_type: :postgres)
+
     setup %{user: user} do
       source = insert(:source, user: user)
 
-      stub(Backends, :get_default_backend, fn ^user -> %{type: :postgres} end)
-
       base_so =
         @postgres_search_attrs
         |> Map.merge(%{source: source, type: :aggregates})
@@ -279,11 +280,11 @@ defmodule Logflare.Logs.SearchOperationsTest do
   end
 
   describe "postgres query defaults and rules" do
+    setup_single_tenant(backend_type: :postgres)
+
     setup %{user: user} do
       source = insert(:source, user: user)
 
-      stub(Backends, :get_default_backend, fn ^user -> %{type: :postgres} end)
-
       so =
         %{@postgres_search_attrs | source: source}
         |> SO.new()
@@ -333,11 +334,11 @@ defmodule Logflare.Logs.SearchOperationsTest do
   end
 
   describe "postgres timestamp filter rules" do
+    setup_single_tenant(backend_type: :postgres)
+
     setup %{user: user} do
       source = insert(:source, user: user)
 
-      stub(Backends, :get_default_backend, fn ^user -> %{type: :postgres} end)
-
       base_so =
         @postgres_search_attrs
         |> Map.merge(%{
@@ -461,14 +462,14 @@ defmodule Logflare.Logs.SearchOperationsTest do
   end
 
   describe "postgres backend adaptor integration" do
+    setup_single_tenant(backend_type: :postgres)
+
     setup %{user: user} do
       Mimic.copy(PostgresAdaptor)
 
       source = insert(:source, user: user)
       backend = build(:backend, type: :postgres)
 
-      stub(Backends, :get_default_backend, fn ^user -> backend end)
-
       base_so =
         %{@postgres_search_attrs | source: source, query: from("test_table")}
         |> SO.new()
@@ -509,15 +510,8 @@ defmodule Logflare.Logs.SearchOperationsTest do
         {:ok, QueryResult.new(rows, %{total_rows: length(rows)})}
       end)
 
-      PostgresAdaptor
-      |> expect(:ecto_to_sql, fn %Ecto.Query{}, [] ->
-        {:ok, {"SELECT * FROM test_table", ["param"]}}
-      end)
-
       result_so = SearchOperations.do_query(base_so)
 
-      assert result_so.sql_string == "SELECT * FROM test_table"
-      assert result_so.sql_params == ["param"]
       assert result_so.rows == rows
       refute result_so.error
     end
@@ -528,12 +522,13 @@ defmodule Logflare.Logs.SearchOperationsTest do
 
       PostgresAdaptor
       |> expect(:execute_query, fn ^backend, %Ecto.Query{}, [query_type: :search] ->
-        {:error, :postgres_failed}
+        raise Postgrex.Error,
+          postgres: %{code: :invalid_sql_statement_name, message: "connection refused"}
       end)
 
       result_so = SearchOperations.do_query(base_so)
 
-      assert result_so.error == :postgres_failed
+      assert %Postgrex.Error{} = result_so.error
     end
 
     test "do_query/1 renames count to value for aggregates and process_query_result/1 adds datetime",
@@ -552,11 +547,6 @@ defmodule Logflare.Logs.SearchOperationsTest do
         {:ok, QueryResult.new(rows, %{total_rows: length(rows)})}
       end)
 
-      PostgresAdaptor
-      |> expect(:ecto_to_sql, fn %Ecto.Query{}, [] ->
-        {:ok, {"SELECT count(*) FROM test_table", []}}
-      end)
-
       result_so =
         %{base_so | type: :aggregates}
         |> SearchOperations.do_query()