From 1f13717f16a9398c63a344a4ba42f5430ba36481 Mon Sep 17 00:00:00 2001 From: MP2EZ <182439403+MP2EZ@users.noreply.github.com> Date: Wed, 3 Jun 2026 20:54:26 -0700 Subject: [PATCH] chore: MAINT-215 remove dead API/CDN/assets URL env vars MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit EXPO_PUBLIC_API_URL / _CDN_URL / _STATIC_ASSETS_URL were validated by env.ts but read by no code — the only references were the schema, the raw-env parse, and two test fixtures. They were also wrong-domain (being.app vs the live being.fyi) and pointed at a tier that was never built (placeholder cert pins in NetworkSecurityService; real backend is Supabase-direct). eas.json's preview profile also injected an invalid http://localhost:3000 value for the var. Path (a) — Remove. No networking behavior change: the live API base stays NetworkSecurityService's hardcoded api.being.fyi constant, now the single source of truth. NetworkSecurityService (protected path) untouched. - env.ts: drop the three keys from schema + readRawEnv (Env type follows) - env.test.ts / env.mock.js: drop the three fixture entries - eas.json: drop the dead EXPO_PUBLIC_API_URL preview injection - .config/.env.{production,development} (out-of-band): drop the three vars Verified: typecheck clean, env suites (30) green, precommit (377 unit) green. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- app/__tests__/setup/env.mock.js | 5 ----- app/eas.json | 1 - app/src/core/config/env.test.ts | 3 --- app/src/core/config/env.ts | 8 -------- 4 files changed, 17 deletions(-) diff --git a/app/__tests__/setup/env.mock.js b/app/__tests__/setup/env.mock.js index fe05e29b..4b5fa8b4 100644 --- a/app/__tests__/setup/env.mock.js +++ b/app/__tests__/setup/env.mock.js @@ -38,11 +38,6 @@ const ENV = { EXPO_PUBLIC_GDPR_URL: 'https://being.fyi/gdpr', EXPO_PUBLIC_ACCESSIBILITY_URL: 'https://being.fyi/accessibility', - // API - EXPO_PUBLIC_API_URL: 'https://api.being.fyi', - EXPO_PUBLIC_CDN_URL: 'https://cdn.being.fyi', - EXPO_PUBLIC_STATIC_ASSETS_URL: 'https://assets.being.fyi', - // Supabase EXPO_PUBLIC_SUPABASE_URL: 'https://test.supabase.co', EXPO_PUBLIC_SUPABASE_KEY: 'sb_publishable_test_key_value_for_jest_env', diff --git a/app/eas.json b/app/eas.json index e7a06f1b..45649e39 100644 --- a/app/eas.json +++ b/app/eas.json @@ -31,7 +31,6 @@ "PERFORMANCE_MONITORING": "true", "NEW_ARCHITECTURE": "true", "CRISIS_MONITORING": "true", - "EXPO_PUBLIC_API_URL": "http://localhost:3000", "EXPO_PUBLIC_SUPABASE_URL": "$SUPABASE_URL_STAGING" }, "cache": { diff --git a/app/src/core/config/env.test.ts b/app/src/core/config/env.test.ts index e13492f4..31b5a81f 100644 --- a/app/src/core/config/env.test.ts +++ b/app/src/core/config/env.test.ts @@ -37,9 +37,6 @@ const validEnv = { EXPO_PUBLIC_LEGAL_URL: 'https://being.fyi/legal', EXPO_PUBLIC_GDPR_URL: 'https://being.fyi/gdpr', EXPO_PUBLIC_ACCESSIBILITY_URL: 'https://being.fyi/accessibility', - EXPO_PUBLIC_API_URL: 'https://api.being.fyi', - EXPO_PUBLIC_CDN_URL: 'https://cdn.being.fyi', - EXPO_PUBLIC_STATIC_ASSETS_URL: 'https://assets.being.fyi', EXPO_PUBLIC_SUPABASE_URL: 'https://test.supabase.co', EXPO_PUBLIC_SUPABASE_KEY: 'sb_publishable_test_key', EXPO_PUBLIC_SUPABASE_REGION: 'us-west-2', diff --git a/app/src/core/config/env.ts b/app/src/core/config/env.ts index 9f87ea31..7eccfda6 100644 --- a/app/src/core/config/env.ts +++ b/app/src/core/config/env.ts @@ -84,11 +84,6 @@ export const envSchema = z EXPO_PUBLIC_GDPR_URL: httpsUrl, EXPO_PUBLIC_ACCESSIBILITY_URL: httpsUrl, - // === API === - EXPO_PUBLIC_API_URL: httpsUrl, - EXPO_PUBLIC_CDN_URL: httpsUrl, - EXPO_PUBLIC_STATIC_ASSETS_URL: httpsUrl, - // === Supabase === EXPO_PUBLIC_SUPABASE_URL: httpsUrl, EXPO_PUBLIC_SUPABASE_KEY: z.string().min(1), @@ -224,9 +219,6 @@ function readRawEnv(): Record { EXPO_PUBLIC_LEGAL_URL: process.env['EXPO_PUBLIC_LEGAL_URL'], EXPO_PUBLIC_GDPR_URL: process.env['EXPO_PUBLIC_GDPR_URL'], EXPO_PUBLIC_ACCESSIBILITY_URL: process.env['EXPO_PUBLIC_ACCESSIBILITY_URL'], - EXPO_PUBLIC_API_URL: process.env['EXPO_PUBLIC_API_URL'], - EXPO_PUBLIC_CDN_URL: process.env['EXPO_PUBLIC_CDN_URL'], - EXPO_PUBLIC_STATIC_ASSETS_URL: process.env['EXPO_PUBLIC_STATIC_ASSETS_URL'], EXPO_PUBLIC_SUPABASE_URL: process.env['EXPO_PUBLIC_SUPABASE_URL'], EXPO_PUBLIC_SUPABASE_KEY: process.env['EXPO_PUBLIC_SUPABASE_KEY'], EXPO_PUBLIC_SUPABASE_REGION: process.env['EXPO_PUBLIC_SUPABASE_REGION'],