From a16dcbc4db7cdf32e856f74566c013ee26e7b479 Mon Sep 17 00:00:00 2001
From: iscd3 <urobertanton@gmail.com>
Date: Wed, 12 Nov 2025 12:09:17 +0200
Subject: [PATCH] Code review 1

Gloantele nu aveau un timp de moarte si ocupau putere de procesare si memorie
---
 code/Bullet.cpp    | 15 +++++++++++++++
 code/Bullet.h      |  9 ++++++---
 code/SpaceShip.cpp |  7 +++++--
 3 files changed, 26 insertions(+), 5 deletions(-)

diff --git a/code/Bullet.cpp b/code/Bullet.cpp
index a33ebd5..130fcf8 100644
--- a/code/Bullet.cpp
+++ b/code/Bullet.cpp
@@ -16,6 +16,7 @@ void Bullet::Display(const Pair& position, sf::RenderWindow& window, sf::FloatRe
     }
 }
 void Bullet::Update(sf::Time dt,Pair player,sf::RenderWindow& window,sf::FloatRect& viewRect) {
+    lifetime-=dt.asSeconds();
     physics.UpdatePosition(dt);
     Display(player,window,viewRect);
 }
@@ -28,7 +29,21 @@ Physics& Bullet::getPhysics() {
 float Bullet::getDamage() const {
     return damage;
 }
+float Bullet::getLifetime() const {
+    return lifetime;
+}
 const float Bullet::speed = 200.f;
+Bullet &Bullet::operator=(const Bullet &other) {
+    if (this!=&other) {
+        shape = other.shape;
+        physics = other.physics;
+        collider = other.collider;
+        damage = other.damage;
+        radius = other.radius;
+        lifetime = other.lifetime;
+    }
+    return *this;
+}
 std::ostream& operator<<(std::ostream& out,const Bullet& bullet) {
     out<<"BULLET\n";
     out<<bullet.physics<<'\n';
diff --git a/code/Bullet.h b/code/Bullet.h
index 8ab1a93..b47a319 100644
--- a/code/Bullet.h
+++ b/code/Bullet.h
@@ -11,8 +11,9 @@ class Bullet {
     sf::CircleShape shape;
     Physics physics;
     Collider collider;
-    const float damage=10;
-    const float radius =5;
+    float damage=10;
+    float radius =5;
+    float lifetime=10;
 public:
     static const float speed;
     explicit Bullet(const Physics& physics) : collider(5.f) {
@@ -27,8 +28,10 @@ class Bullet {
     sf::CircleShape& getShape();
     Physics& getPhysics();
     float getDamage() const;
-    void Update(sf::Time dt,Pair player,sf::RenderWindow& window,sf::FloatRect& viewRect);
+    float getLifetime() const;
+    void Update(sf::Time dt,Pair player,sf::RenderWindow& window,sf::FloatRect& viewRects);
     void Display(const Pair& position, sf::RenderWindow& window, sf::FloatRect& viewRect);
+    Bullet &operator=(const Bullet &other);
     friend std::ostream& operator<<(std::ostream& out,const Bullet& bullet);
 };
 #endif //OOP_BULLET_H
\ No newline at end of file
diff --git a/code/SpaceShip.cpp b/code/SpaceShip.cpp
index 1aff749..8c90231 100644
--- a/code/SpaceShip.cpp
+++ b/code/SpaceShip.cpp
@@ -87,8 +87,11 @@ void SpaceShip::alignToPlanet(const Physics& planetPhys) {
 
 }
 void SpaceShip::UpdateBullets(sf::Time dt,sf::RenderWindow& window,sf::FloatRect& viewRect) {
-    for (auto& i:bullets) {
-        i.Update(dt,getPhysics().getPosition(),window,viewRect);
+    for (int i=0;i<bullets.size();i++) {
+        bullets[i].Update(dt,getPhysics().getPosition(),window,viewRect);
+        if (bullets[i].getLifetime()<0) {
+            bullets.erase(bullets.begin()+i);
+        }
     }
 }
 Collider SpaceShip::getCollider() {