Added tests for the import experiment feature

* #35

Author: Ezetowers

MLC/GUI/ExperimentsManager.py

@@ -3,6 +3,7 @@
 import time
 
 from MLC.api.mlc import DuplicatedExperimentError
+from MLC.api.mlc import ImportExperimentPathNotExistException
 from MLC.Common import util
 from MLC.Log.log import get_gui_logger
 from MLC.mlc_parameters.mlc_parameters import Config
@@ -100,7 +101,19 @@ def remove_experiment(self, experiment_name):
 
     def import_experiment(self, experiment_path):
         experiment_name = os.path.split(experiment_path)[1].split(".")[0]
-        self._mlc_local.import_experiment(experiment_path)
+        try:
+            self._mlc_local.import_experiment(experiment_path)
+        except DuplicatedExperimentError:
+            logger.error("Experiment {0} could not be imported. "
+                         "It already exists.".format(experiment_name))
+        except ImportExperimentPathNotExistException, err:
+            logger.error("Experiment {0} could not be imported. "
+                         "Experiment path given does not exists. Exception msg: {1}"
+                         .format(experiment_name, err))
+        except Exception, err:
+            logger.error("Experiment {0} could not be imported. {1}"
+                         .format(experiment_name, err))
+
         self._experiment_list.append(experiment_name)
         self.load_experiment_info(experiment_name)
 

MLC/api/MLCLocal.py

@@ -16,6 +16,7 @@
 from MLC.api.mlc import InvalidExperimentException
 from MLC.api.mlc import EvaluationScriptNotExistException
 from MLC.api.mlc import PreevaluationScriptNotExistException
+from MLC.api.mlc import ImportExperimentPathNotExistException
 from MLC.Application import Application
 from MLC.config import get_templates_path
 from MLC.config import set_working_directory
@@ -117,6 +118,9 @@ def delete_experiment(self, experiment_name):
             logger.info("[MLC_LOCAL] Error while trying to delete experiment file: {0}".format(file))
 
     def import_experiment(self, experiment_path):
+        if not os.path.exists(experiment_path):
+            raise ImportExperimentPathNotExistException(experiment_path)
+
         experiment_name = os.path.split(experiment_path)[1].split(".")[0]
         self._create_experiment_dir(experiment_name)
 

MLC/api/mlc.py

@@ -35,6 +35,11 @@ def __init__(self, experiment_name, script_path):
                                     "existent evaluation script. Script: {1}"
                                     .format(experiment_name, script_path))
 
+class ImportExperimentPathNotExistException(MLCException):
+
+    def __init__(self, experiment_path):
+        MLCException.__init__(self, "Import Experiment Error: Path {0} does not exists."
+                                    .format(experiment_path))
 
 class MLC:
 

tests/mlc/api/test_mlc.py

@@ -27,7 +27,6 @@ class MLCWorkspaceTest(unittest.TestCase):
     NEW_EXPERIMENT = "test_new_experiment"
     NEW_CONFIGURATION = None
 
-
     @classmethod
     def setUpClass(cls):
         try:
@@ -296,6 +295,41 @@ def test_go_and_get_generations(self):
             os.unlink(os.path.join(MLCWorkspaceTest.WORKSPACE_DIR, "test_go_and_check") + ".mlc")
             pass
 
+    def test_import_non_existent_experiment(self):
+        mlc = MLCLocal(working_dir=MLCWorkspaceTest.WORKSPACE_DIR)
+
+        import_experiment_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
+                                              "test4.mlc")
+        mlc.import_experiment(import_experiment_path)
+        self.assertTrue("test4" in mlc.get_workspace_experiments())
+        mlc.delete_experiment("test4")
+
+    def test_import_existent_experiment(self):
+        mlc = MLCLocal(working_dir=MLCWorkspaceTest.WORKSPACE_DIR)
+        mlc.new_experiment("test4", MLCWorkspaceTest.ORIGINAL_CONFIGURATION)
+
+        import_experiment_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
+                                              "test4.mlc")
+        try:
+            mlc.import_experiment(import_experiment_path)
+            self.assertTrue(False)
+        except MLC.api.mlc.DuplicatedExperimentError:
+            self.assertTrue(True)
+        finally:
+            mlc.delete_experiment("test4")
+
+    def test_import_experiment_with_erroneous_path(self):
+        mlc = MLCLocal(working_dir=MLCWorkspaceTest.WORKSPACE_DIR)
+        import_experiment_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
+                                              "test5.mlc")
+        try:
+            mlc.import_experiment(import_experiment_path)
+            self.assertTrue(False)
+            mlc.delete_experiment("test5")
+        except MLC.api.mlc.ImportExperimentPathNotExistException:
+            self.assertTrue(True)
+            self.assertFalse("test5" in mlc.get_workspace_experiments())
+
     def _assert_key_value(self, dictionary, key, value):
         self.assertIsInstance(dictionary, dict)
         self.assertIn(key, dictionary)