feat: extract generate-action-types CLI into @metamask/messenger-cli (#8378)

## Explanation

The `generate-action-types` CLI tool currently lives inside
`@metamask/messenger`. Consumers may use different ESLint or TypeScript
versions, which complicates usage when these are peer dependencies. This
PR extracts the CLI into its own dedicated package
(`@metamask/messenger-cli`) so consumers can install it as a
devDependency with their own ESLint/TypeScript versions.

### Changes

- **New `@metamask/messenger-cli` package** with all CLI source files
and tests (100% coverage).
- `eslint` and `typescript` are peer dependencies (uses the project's
versions to avoid formatting mismatches).
  - `@metamask/utils` and `yargs` are regular dependencies.
  - CLI-only package — no public API exports, no typedoc.
- Binary: `messenger-action-types --generate` / `messenger-action-types
--check`
- **`@metamask/messenger` is unchanged for consumers** (non-breaking).
The existing CLI and binary remain, with a deprecation warning pointing
to the new package.
- **Per-package scripts** renamed to `messenger-action-types:generate`
and `messenger-action-types:check` (matching
`changelog:update`/`changelog:validate` pattern).
- **Removed `tsx` devDependency** from ~49 consumer packages (no longer
needed per-package).
- **Updated root scripts** to `messenger-action-types:check` and
`messenger-action-types:generate`.
- **Updated CI, docs, and metadata** (`lint-build-test.yml`,
`controller-guidelines.md`, `teams.json`, `CODEOWNERS`,
`eslint.config.mjs`, `yarn.config.cjs`).

This package will also serve as the home for `@metamask/messenger-docs`
in a follow-up, consolidating all messenger CLI tooling in one place.

## References

- Related to #8264

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by updating changelogs
for packages I've changed
- [ ] I've introduced breaking changes in this PR and have prepared
draft pull requests for clients and consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Mostly build/dev-tooling changes, but it rewires lint/CI scripts and
per-package workflows; mistakes could break generation checks or CI
across many workspaces.
> 
> **Overview**
> Introduces a new workspace package, `@metamask/messenger-cli`, that
provides the `messenger-action-types` binary to **generate** and
**check** `*-method-action-types.ts` files (including source discovery,
JSDoc extraction, optional ESLint formatting, and full test coverage).
> 
> Updates the monorepo to use the new CLI everywhere: root
`lint`/`lint:fix` and CI now run `messenger-action-types:*`, and many
workspace `package.json` scripts are renamed from
`generate-method-action-types` to
`messenger-action-types:generate`/`:check` pointing at the new CLI.
> 
> Marks the old `@metamask/messenger` `messenger-generate-action-types`
CLI as **deprecated** via a runtime warning, and updates
docs/metadata/config (`README`, controller guidelines, `CODEOWNERS`,
`teams.json`, `eslint.config.mjs`, `tsconfig*`, `yarn.config.cjs`) to
register the new package and its build exceptions.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
ab18925. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>

Author: cryptodev-2s

.github/CODEOWNERS

@@ -86,6 +86,7 @@
 /packages/controller-utils             @MetaMask/core-platform
 /packages/eth-json-rpc-middleware      @MetaMask/core-platform
 /packages/messenger                    @MetaMask/core-platform
+/packages/messenger-cli                @MetaMask/core-platform
 /packages/sample-controllers           @MetaMask/core-platform
 /packages/polling-controller           @MetaMask/core-platform
 /packages/preferences-controller       @MetaMask/core-platform

.github/workflows/lint-build-test.yml

@@ -38,7 +38,7 @@ jobs:
           - constraints
           - lint:dependencies
           - lint:teams
-          - generate-method-action-types:check
+          - messenger-action-types:check
           - readme-content:check
     steps:
       - name: Checkout and setup environment

README.md

@@ -64,6 +64,7 @@ Each package in this repository has its own README where you can find installati
 - [`@metamask/logging-controller`](packages/logging-controller)
 - [`@metamask/message-manager`](packages/message-manager)
 - [`@metamask/messenger`](packages/messenger)
+- [`@metamask/messenger-cli`](packages/messenger-cli)
 - [`@metamask/money-account-controller`](packages/money-account-controller)
 - [`@metamask/multichain-account-service`](packages/multichain-account-service)
 - [`@metamask/multichain-api-middleware`](packages/multichain-api-middleware)
@@ -149,6 +150,7 @@ linkStyle default opacity:0.5
   logging_controller(["@metamask/logging-controller"]);
   message_manager(["@metamask/message-manager"]);
   messenger(["@metamask/messenger"]);
+  messenger_cli(["@metamask/messenger-cli"]);
   money_account_controller(["@metamask/money-account-controller"]);
   multichain_account_service(["@metamask/multichain-account-service"]);
   multichain_api_middleware(["@metamask/multichain-api-middleware"]);

docs/code-guidelines/controller-guidelines.md

@@ -457,7 +457,7 @@ Instead, you can follow this process:
 
 1. Define a constant in your controller file called `MESSENGER_EXPOSED_METHODS`, listing the methods you want to expose.
 2. Remove manual action registrations; instead, call `registerMethodActionHandlers` and pass `MESSENGER_EXPOSED_METHODS`.
-3. Remove messenger action types; instead, run `yarn generate-method-action-types`. This will create a file called `${ControllerName}-method-action-types.ts`, which exports a type called `${ControllerName}MethodActions`.
+3. Remove messenger action types; instead, run `yarn messenger-action-types:generate`. This will create a file called `${ControllerName}-method-action-types.ts`, which exports a type called `${ControllerName}MethodActions`.
 4. Import `${ControllerName}-method-action-types.ts` in your controller file, and add `${ControllerName}MethodActions` to `${ControllerName}Actions`.
 5. Export the action types from `${ControllerName}-method-action-types.ts` in your package's `index.ts` file. Do **not** export the `${ControllerName}MethodActions` type.
 

eslint.config.mjs

@@ -293,6 +293,12 @@ const config = createConfig([
       'import-x/no-nodejs-modules': 'off',
     },
   },
+  {
+    files: ['packages/messenger-cli/src/**/*.{js,ts}'],
+    rules: {
+      'import-x/no-nodejs-modules': 'off',
+    },
+  },
   {
     files: [
       'packages/notification-services-controller/src/NotificationServicesPushController/services/push/*-web.ts',

package.json

@@ -21,16 +21,16 @@
     "changelog:update": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:update",
     "changelog:validate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:validate",
     "create-package": "tsx scripts/create-package",
-    "generate-method-action-types": "yarn workspaces foreach --all --parallel --interlaced --verbose run generate-method-action-types",
-    "generate-method-action-types:check": "yarn generate-method-action-types --check",
-    "lint": "yarn lint:eslint && echo && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:teams && yarn generate-method-action-types --check && yarn readme-content:check",
+    "lint": "yarn lint:eslint && echo && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:teams && yarn messenger-action-types:check && yarn readme-content:check",
     "lint:dependencies": "depcheck && yarn dedupe --check",
     "lint:dependencies:fix": "depcheck && yarn dedupe",
     "lint:eslint": "yarn build:only-clean && NODE_OPTIONS='--max-old-space-size=6144' yarn eslint",
-    "lint:fix": "yarn lint:eslint --fix --prune-suppressions && echo && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix && yarn generate-method-action-types --fix && yarn readme-content:update",
+    "lint:fix": "yarn lint:eslint --fix --prune-suppressions && echo && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix && yarn messenger-action-types:generate && yarn readme-content:update",
     "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path .gitignore",
     "lint:misc:check": "yarn lint:misc --check",
     "lint:teams": "tsx scripts/lint-teams-json.ts",
+    "messenger-action-types:check": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run messenger-action-types:check",
+    "messenger-action-types:generate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run messenger-action-types:generate",
     "prepack": "./scripts/prepack.sh",
     "prepare-preview-builds": "./scripts/prepare-preview-builds.sh",
     "readme-content:check": "tsx scripts/update-readme-content.ts --check",

packages/account-tree-controller/package.json

@@ -40,7 +40,8 @@
     "build:docs": "typedoc",
     "changelog:update": "../../scripts/update-changelog.sh @metamask/account-tree-controller",
     "changelog:validate": "../../scripts/validate-changelog.sh @metamask/account-tree-controller",
-    "generate-method-action-types": "tsx ../../packages/messenger/src/generate-action-types/cli.ts",
+    "messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
+    "messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
     "since-latest-release": "../../scripts/since-latest-release.sh",
     "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
     "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",

packages/accounts-controller/package.json

@@ -40,7 +40,8 @@
     "build:docs": "typedoc",
     "changelog:update": "../../scripts/update-changelog.sh @metamask/accounts-controller",
     "changelog:validate": "../../scripts/validate-changelog.sh @metamask/accounts-controller",
-    "generate-method-action-types": "tsx ../../packages/messenger/src/generate-action-types/cli.ts",
+    "messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
+    "messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
     "since-latest-release": "../../scripts/since-latest-release.sh",
     "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
     "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",

packages/address-book-controller/package.json

@@ -40,7 +40,8 @@
     "build:docs": "typedoc",
     "changelog:update": "../../scripts/update-changelog.sh @metamask/address-book-controller",
     "changelog:validate": "../../scripts/validate-changelog.sh @metamask/address-book-controller",
-    "generate-method-action-types": "tsx ../../packages/messenger/src/generate-action-types/cli.ts",
+    "messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
+    "messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
     "since-latest-release": "../../scripts/since-latest-release.sh",
     "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
     "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",

packages/analytics-controller/package.json

@@ -40,7 +40,8 @@
     "build:docs": "typedoc",
     "changelog:update": "../../scripts/update-changelog.sh @metamask/analytics-controller",
     "changelog:validate": "../../scripts/validate-changelog.sh @metamask/analytics-controller",
-    "generate-method-action-types": "tsx ../../packages/messenger/src/generate-action-types/cli.ts",
+    "messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
+    "messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
     "since-latest-release": "../../scripts/since-latest-release.sh",
     "test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
     "test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",