From bc21043313796e79b13a3981836222129bb4e730 Mon Sep 17 00:00:00 2001 From: Charlie Tonneslan Date: Sun, 17 May 2026 19:39:35 -0400 Subject: [PATCH] notice(non_ascii_or_non_printable_char): use standard fieldName The serialized output of this notice carries the offending column under the key 'columnName', but every other notice uses 'fieldName' (see InvalidCurrencyNotice, InvalidPhoneNumberNotice, etc.). Pipelines consuming the validator output have to special-case this one validator. Just match the convention. Callers already pass cellContext.fieldName() into the constructor, so no behavior changes - only the JSON key the field reflects to. Closes #1205. Signed-off-by: Charlie Tonneslan --- .../notice/NonAsciiOrNonPrintableCharNotice.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NonAsciiOrNonPrintableCharNotice.java b/core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NonAsciiOrNonPrintableCharNotice.java index aa76d8bda9..b3ca53565b 100644 --- a/core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NonAsciiOrNonPrintableCharNotice.java +++ b/core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NonAsciiOrNonPrintableCharNotice.java @@ -34,17 +34,17 @@ public class NonAsciiOrNonPrintableCharNotice extends ValidationNotice { /** Row number of the faulty record. */ private final int csvRowNumber; - /** Name of the column where the error occurred. */ - private final String columnName; + /** Faulty record's field name. */ + private final String fieldName; /** Faulty value. */ private final String fieldValue; public NonAsciiOrNonPrintableCharNotice( - String filename, int csvRowNumber, String columnName, String fieldValue) { + String filename, int csvRowNumber, String fieldName, String fieldValue) { this.filename = filename; this.csvRowNumber = csvRowNumber; - this.columnName = columnName; + this.fieldName = fieldName; this.fieldValue = fieldValue; } }