[Good Issue]:

[MonaaEid]

⚠️ Good First Issue — Candidate

This issue is not yet a confirmed Good First Issue.
It is being evaluated for suitability and may require
clarification or refinement before it is ready to be picked up.

Please wait for maintainer confirmation before starting work.

Maintainers and reviewers can read more about Good First Issues:
docs/maintainers/good_first_issue_guidelines.md

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed or have made minimal contributions to Hiero Python SDK.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues in find a good first issue is to help you make your first contribution to the Hiero Python SDK.

👾 Description of the issue

Edit here. Example provided below.

💡 Proposed Solution

Edit here. Example provided below.

👩‍💻 Implementation Steps

Edit here. Example provided below.

✅ Acceptance Criteria

To be able to merge a pull request for this issue, we need:

• Changelog Entry: Correct changelog entry (please link to the documentation - see guide)
• Signed commits: commits must be DCO and GPG key signed (see guide)
• All Tests Pass: our workflow checks like unit and integration tests must pass
• Issue is Solved: The implementation fully addresses the issue requirements as described above
• No Further Changes are Made: Code review feedback has been addressed and no further changes are requested

📋 Step-by-Step Contribution Guide

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow.

• Claim this issue: Comment below that you are interested in working on the issue. Without assignment, your pull requests might be closed and the issue given to another developer.
• Wait for assignment: A community member with the given rights will add you as an assignee of the issue
• Fork, Branch and Work on the issue: Create a copy of the repository, create a branch for the issue and solve the problem. For instructions, please read our Contributing guide file. Further help can be found at Set-up Training and Workflow Training.
• DCO and GPG key sign each commit : each commit must be -s and -S signed. An explanation on how to do this is at Signing Guide
• Add a Changelog Entry : your pull request will require a changelog. Read Changelog Entry Guide to learn how.
• Push and Create a Pull Request : Once your issue is resolved, and your commits are signed, and you have a changelog entry, push your changes and create a pull request. Detailed instructions can be found at Submit PR Training, part of Workflow Training.
• You did it 🎉: A maintainer or committer will review your pull request and provide feedback. If approved, we will merge the fix in the main branch. Thanks for being part of the Hiero community as an open-source contributor ❤️

IMPORTANT Your pull request CANNOT BE MERGED until you add a changelog entry AND sign your commits each with git commit -S -s -m "chore: your commit message" with a GPG key setup.

🤔 Additional Information

For more help, we have extensive documentation attributes:

• SDK Developer Docs
• SDK Developer Training

Additionally, we invite you to join our community on our Discord server.

We also invite you to attend each Wednesday, 2pm UTC our Python SDK Office Hour and Community Calls. The Python SDK Office hour is for hands-on-help and the Community Call for general community discussion.

You can also ask for help in a comment below!

[github-actions]

🚨 Attention Team 🚨

@team-python-sdk/maintainers @team-python-sdk/committers @team-python-sdk/triage

A new P0 issue has been created: #32 - [Good Issue]:
Please prioritize this issue accordingly.

Best Regards,
Automated Notification System

[github-actions]

@coderabbitai plan

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Fetch details of issue `#32`
gh issue view 32 --json title,body,labels,comments --jq '{title: .title, body: .body, labels: [.labels[].name], comments: [.comments[] | {author: .author.login, body: .body}]}'

Length of output: 275

---

🏁 Script executed:

#!/bin/bash
# Search for TokenDissociateTransaction in the codebase
echo "=== Searching for TokenDissociateTransaction ==="
rg -i "TokenDissociate" -n -C3

echo -e "\n=== Searching for token dissociate related files ==="
fd -i dissociate

echo -e "\n=== Check for related PRs ==="
gh pr list --search "dissociate" --json number,title,state,author --limit 10

echo -e "\n=== List recent PRs to understand the pattern ==="
gh pr list --state all --json number,title,state,createdAt --limit 5

Length of output: 31239

---

🏁 Script executed:

#!/bin/bash
# Check for PRs that reference issue `#32`
echo "=== PRs referencing issue `#32` ==="
gh pr list --search "#32" --state all --json number,title,state,body --limit 20

echo -e "\n=== Check if there are any related commits ==="
git log --all --grep="#32" --oneline --no-decorate | head -20

echo -e "\n=== Check who created the issue and when ==="
gh issue view 32 --json author,createdAt,updatedAt,url --jq '{author: .author.login, created: .createdAt, updated: .updatedAt, url: .url}'

echo -e "\n=== Check if there are any linked PRs or issues ==="
gh issue view 32 --json projectItems,milestone,assignees --jq '{milestone: .milestone, assignees: [.assignees[].login], projectItems: .projectItems}'

Length of output: 33029

---

@github-actions I've investigated #32 and found that it's actually a merged pull request, not an open issue. Here's what I discovered:

Summary

#32 is a merged PR from January 2025, not a new issue requiring a plan. The TokenDissociateTransaction feature has been fully implemented and merged into the codebase.

Current Status

✅ Fully Implemented - The TokenDissociateTransaction feature includes:

• Source Code: src/hiero_sdk_python/tokens/token_dissociate_transaction.py
• Unit Tests: tests/unit/token_dissociate_transaction_test.py
• Integration Tests: tests/integration/token_dissociate_transaction_e2e_test.py
• Examples: examples/tokens/token_dissociate_transaction.py
• Documentation: Multiple documentation references and CHANGELOG entry
• Exports: Properly exported in __init__.py and transaction registry

Original PR Details

• Author: exploreriii
• Merged: January 2025 (commit: 8c61874)
• Description: Created TokenDissociate in similar format, with passing local tests and solo network tests

Recommendation

No action is needed. The P0 notification appears to be triggered by a configuration issue that's treating merged pull requests as new issues. You may want to review the issue notification workflow to ensure it only triggers on actual open issues, not merged PRs.