-
Notifications
You must be signed in to change notification settings - Fork 1
Frontend ESLint errors: 159 issues across 20 files #313
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Summary
During project health check, running npm run lint in the frontend directory revealed 159 errors and 4 warnings across 20 files.
Categories of Errors
Critical Issues (Production Code)
-
Undefined variables in utility code
src/utils/stacks.js:134:getMainnetAddressis not definedvite.config.js:96:__dirnameis not defined (ES module context)
-
Unused imports and variables (11 instances)
AdminDashboard.jsx: unusedIconRecentTips.jsx: unusedfetchTipMessagesSendTip.jsx: unusedisContractPrincipal,recipientWarningTelemetryDashboard.jsx: unusedIconTipHistory.jsx: unuseduseMemoTipContext.jsx: unusedclearPageCachecontracts.js: 4 unused validation imports
-
React Hooks violations
PlatformStats.jsx:36: setState called synchronously in useEffecttx-status.jsx:97: setState called synchronously in useEffectuseFeedConnectionStatus.js:19: impure functionDate.nowcalled during renderProfileManager.jsx:47: missing dependency in useEffectuseCachedData.js: ref cleanup and missing dependencies
-
Fast refresh violations (6 instances)
- Context files exporting non-components alongside contexts
Test File Issues (72 errors)
globalis not defined in test files (needs eslint config for test environment)processis not defined in Node.js scripts (needs eslint config for Node environment)afterEach/beforeEachnot defined in some test files
Reproduction
cd frontend
npm run lintExpected Behavior
npm run lint should pass with no errors.
Proposed Fix
- Fix production code issues (undefined variables, unused imports, React hooks)
- Update ESLint config to recognize test globals (
global,describe,it, etc.) - Update ESLint config to recognize Node.js globals in scripts directory
- Refactor context files to separate hooks from context definitions
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working