51 overhaul of screenshot modal#88
Conversation
|
Might not be able to review this in time for today's release. Will get to this next week. |
|
Follow the same visual language for Export and cancel buttons as already exists in the annotations overlay for example: 
|
| workerData.location, | ||
| workerData.screenshot, | ||
| workerData.associatedAnnotations | ||
| ).then((err) => { |
There was a problem hiding this comment.
Apparently this doesn't work anymore.
$ node -e "const f = async () => { throw new Error('oops') }; f().then((err) => { if (err) console.log('caught here'); else console.log('success') }).catch((err) => console.log('actually caught'))"
actually caught
You need to use .catch. I think this pattern is used in a few other places as well.
| .replaceAll(':', '-') | ||
| .replace(',', '_') | ||
| try { | ||
| fs.copyFileSync(imagePath, path.join(tmpPath, imageName + '.jpg')) |
There was a problem hiding this comment.
Wouldn't it be better to use fs.promises.copyFile here since this is an async function to avoid blocking. It doesn't matter so much since this happens in a worker but still good code hygiene.
|
I have fixed the buttons and error catch. |
2 participants
Screenshot modal with zooming and associated annotations
Export of zip file containing screenshot and associated annotations in json format with an export_screenshot worker (adapted from export_screenshots worker; currently not implemented in server/)