Skip to content

Improve missing video handling for large files#90

Open
kashan307 wants to merge 1 commit into
Movie-Analytics:mainfrom
kashan307:missing-video-location
Open

Improve missing video handling for large files#90
kashan307 wants to merge 1 commit into
Movie-Analytics:mainfrom
kashan307:missing-video-location

Conversation

@kashan307

Copy link
Copy Markdown
Contributor

Follow-up improvements for missing video handling.

Changes:

  • Replace timeout-based detection with file existence check
  • Improve handling for large video files
  • Refactor async video loading logic
  • Add i18n support for missing video dialog

"screenshots": "screenshot generation",
"electronBrowser": "works in the browser or via Electron as a desktop application"
"shotboundary": "automatic shot boundary detection",
"elan": "Import and export to ELAN",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, these are good. But I don't think they belong in this PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! These are actually existing entries, I just capitalized the first word of each sentence and added spacing. No new keys were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants