added fix for the failed tests

Author: Mukuldev21

fixtures/LoginData.ts

@@ -12,7 +12,7 @@ export const loginData = {
         location: "Inpatient Ward"
     },
     errorMessages: {
-        invalidCredentials: "Invalid username or password. Invalid username/password. Please try again. try again.",
+        invalidCredentials: "Invalid username/password. Please try again",
         locationRequired: "You must choose a location!"
     },
     sessionLocations: [

pages/LoginPage.ts

@@ -18,43 +18,60 @@ export class LoginPage {
     this.usernameInput = page.locator('input#username');
     this.passwordInput = page.locator('input#password');
     this.sessionLocationSelect = page.locator('ul#sessionLocation.select');
-    this.loginButton = page.locator('button#loginButton');
+    this.loginButton = page.locator('input#loginButton.btn.confirm');
     this.errorMessage = page.locator('.alert.alert-danger');
     this.errorMessageSessionLocationSelect = page.locator('#sessionLocationError');
  }
 
+    
     async navigate() {
         await this.page.goto(this.baseUrl);
+        await this.page.waitForLoadState('domcontentloaded');
         await expect(this.page).toHaveTitle(this.expectedTitle);
     }
+   
     async login(username: string, password: string, location: string) {
-        await this.usernameInput.fill(username);
-        await this.passwordInput.fill(password);
-        await this.sessionLocationSelect.selectOption(location);
-        await this.loginButton.click();
+    await this.usernameInput.fill(username);
+    await this.passwordInput.fill(password);
+    //await this.page.locator(`ul#sessionLocation.select >> text=${location}`).click();
+    if (location) {
+        await this.page.locator(`ul#sessionLocation.select >> text=${location}`).click();
     }
+    await this.loginButton.click();
+}
 
     async invalidLogin(username: string, password: string, location: string) {
-        await this.usernameInput.fill(username);
-        await this.passwordInput.fill(password);
-        await this.sessionLocationSelect.selectOption(location);
-        await this.loginButton.click();
+    await this.usernameInput.fill(username);
+    await this.passwordInput.fill(password);
+    //await this.page.locator(`ul#sessionLocation.select >> text=${location}`).click();
+    if (location) {
+        await this.page.locator(`ul#sessionLocation.select >> text=${location}`).click();
     }
+    await this.loginButton.click();
+}
+
+    async loginWithoutLocation(username: string, password: string) {
+    await this.usernameInput.fill(username);
+    await this.passwordInput.fill(password);
+    await this.loginButton.click();
+}
 
     async assertErrorMessage(expectedMessage: string) {
-        await expect(this.errorMessage).toHaveText(expectedMessage);
+        await expect(this.errorMessage).toContainText(expectedMessage);
     }
 
     async assertSessionLocationError(expectedMessage: string) {
-        await expect(this.errorMessageSessionLocationSelect).toHaveText(expectedMessage);
+        await expect(this.errorMessageSessionLocationSelect).toContainText(expectedMessage);
     }
+    
     async verifySessionLocations(expectedLocations: string[]) {
-        const options = this.sessionLocationSelect.locator('option');
-        const optionCount = await options.count();
-        let actualLocations: string[] = [];
-        for (let i = 0; i < optionCount; i++) {
-            actualLocations.push(await options.nth(i).innerText());
-        }
-        expect(actualLocations).toEqual(expectedLocations);
-        }
-    }
+    const options = this.sessionLocationSelect.locator('li');
+    const optionCount = await options.count();
+    let actualLocations: string[] = [];
+    for (let i = 0; i < optionCount; i++) {
+        actualLocations.push((await options.nth(i).innerText()).trim());
+    }
+    expect(actualLocations.sort()).toEqual(expectedLocations.sort());
+}
+
+}

tests/LoginTest.spec.ts

@@ -31,8 +31,8 @@ test.describe('Login Tests', () => {
         await loginPage.assertErrorMessage(errorMessages.invalidCredentials);
     });
     test('Login without selecting session location', async () => {
-        await loginPage.login(validUser.username, validUser.password, "");
-        await loginPage.errorMessage.isVisible();
+        await loginPage.loginWithoutLocation(validUser.username, validUser.password);
+        await loginPage.errorMessageSessionLocationSelect.isVisible();
         await loginPage.assertSessionLocationError(errorMessages.locationRequired);
     });