-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
I'm working through the (clear and helpful) documentation. Though i installed ect from PyPI using pip3, i encountered some bugs in 3.2. Tutorial, possibly due to breaking changes in more recent versions of the package:
- The line
from ect import ECT, EmbeddedComplex, create_example_graphfails withImportError: cannot import name 'create_example_graph' from 'ect' (/Library/Frameworks/Python.framework/Versions/3.14/lib/python3.14/site-packages/ect/__init__.py). - The
add_nodelines are missing brackets, e.g.G.add_node('A', 0,0)needs to beG.add_node('A', [0,0]). - Later commands using e.g.
plot_angle_circleandrescale_to_unit_diskfail as these names/attributes are not defined.
I apologize if these should be straightforward to resolve; Python is not my first language.
So that readers can reproduce the example in the manuscript, it would be helpful to link to this tutorial, or else include minimal source code to generate the figures.
Part of this JOSS review.
Metadata
Metadata
Assignees
Labels
No labels