diff --git a/.Jules/palette.md b/.Jules/palette.md index f61603c8..73dab83a 100644 --- a/.Jules/palette.md +++ b/.Jules/palette.md @@ -25,3 +25,6 @@ ## 2026-06-23 - [SwiftUI Button Accessibility] **Learning:** Found a pattern where SwiftUI icon-only buttons or minimal UI elements were given `.help()` modifiers for hover tooltips but lacked `.accessibilityLabel()` modifiers for screen readers. **Action:** When adding `.help()` to buttons, always pair it with a corresponding `.accessibilityLabel()` to ensure full accessibility. +## 2026-07-05 - [Dynamic Context for List Actions] +**Learning:** In repeated lists or loops, action buttons (like Edit/Delete) require dynamic context in their `.help()` and `.accessibilityLabel()` modifiers (e.g., fallback to 'Unnamed' if empty) to disambiguate the action for screen reader users and prevent confusion. +**Action:** Ensure dynamic labels are applied to all list items. diff --git a/XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift b/XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift index 211ecb1e..b2ce8c8f 100644 --- a/XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift +++ b/XboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swift @@ -155,8 +155,8 @@ struct SharedMacroRow: View { .foregroundColor(.accentColor) } .buttonStyle(.borderless) - .help("Edit in shared library") - .accessibilityLabel("Edit in shared library") + .help(macro.name.isEmpty ? "Edit in shared library" : "Edit \(macro.name) in shared library") + .accessibilityLabel(macro.name.isEmpty ? "Edit in shared library" : "Edit \(macro.name) in shared library") } .padding(.horizontal, 12) .padding(.vertical, 8) @@ -206,16 +206,16 @@ struct MacroRow: View { .foregroundColor(.accentColor) } .buttonStyle(.borderless) - .help("Edit") - .accessibilityLabel("Edit") + .help(macro.name.isEmpty ? "Edit" : "Edit \(macro.name)") + .accessibilityLabel(macro.name.isEmpty ? "Edit" : "Edit \(macro.name)") Button(action: onDelete) { Image(systemName: "trash") .foregroundColor(.red.opacity(0.8)) } .buttonStyle(.borderless) - .help("Delete") - .accessibilityLabel("Delete") + .help(macro.name.isEmpty ? "Delete" : "Delete \(macro.name)") + .accessibilityLabel(macro.name.isEmpty ? "Delete" : "Delete \(macro.name)") } } .padding(.horizontal, 12) diff --git a/XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift b/XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift index 40c6f5ff..e695f195 100644 --- a/XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift +++ b/XboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift @@ -222,16 +222,16 @@ struct ScriptRow: View { .foregroundColor(.accentColor) } .buttonStyle(.borderless) - .help("Edit") - .accessibilityLabel("Edit") + .help(script.name.isEmpty ? "Edit" : "Edit \(script.name)") + .accessibilityLabel(script.name.isEmpty ? "Edit" : "Edit \(script.name)") Button(action: onDelete) { Image(systemName: "trash") .foregroundColor(.red.opacity(0.8)) } .buttonStyle(.borderless) - .help("Delete") - .accessibilityLabel("Delete") + .help(script.name.isEmpty ? "Delete" : "Delete \(script.name)") + .accessibilityLabel(script.name.isEmpty ? "Delete" : "Delete \(script.name)") } } .padding(.horizontal, 12)