refactor(onboard): run live sequence with record-only steps#4472
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds resume-machine repair helpers and tests, integrates repair into onboarding resume initialization, configures the runtime boundary to avoid automatic machine updates, and explicitly records an initial preflight state. ChangesResume-Machine Repair and Onboarding Integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Auto-dispatched E2E: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
E2E Scenario Advisor RecommendationRequired scenario E2E: Dispatch required scenario E2E:
Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
PR Review AdvisorFindings: 0 needs attention, 0 worth checking, 0 nice ideas Consider writing more tests for
This is an automated advisory review. A human maintainer must make the final merge decision. |
Resolve PR #4471 against current main while preserving the ordered provider/inference FSM result sequence. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Resolve PR #4472 against the updated provider result sequence base while keeping live onboarding step mutations record-only. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
…onboard-fsm-live-record-only-sequence
Bring PR #4472 current with origin/main. Repair failed resume sessions. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Selective E2E Results — ✅ All requested jobs passedRun: 27105680547
|
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Selective E2E Results — ❌ Some jobs failedRun: 27105755137
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Selective E2E Results — ✅ All requested jobs passedRun: 27107451958
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
<!-- markdownlint-disable MD041 --> ## Summary Repairs reopened terminal onboarding machine snapshots before the record-only resume path replays compatibility phases. It also makes deployment messaging verification check sandbox-scoped bridge provider names and skip tokenless WhatsApp provider checks, removing the misleading missing-provider warning from rebuild logs. ## Related Issue Refs #4533 Context: #4472 ## Changes - Repair `complete` machine snapshots that have been reopened for resume/rebuild using legacy step state, while leaving non-resumable completed sessions untouched. - Add record-only resume regression coverage for reopened complete snapshots. - Verify messaging providers with sandbox-scoped bridge provider names and skip provider checks for tokenless WhatsApp. - Add deployment verification tests for channel-to-provider mapping and tokenless channels. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files` passes - [x] `npm test` passes - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- <!-- DCO sign-off required by CI. Run: git config user.name && git config user.email --> Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved session recovery to repair certain completed workflow snapshots while leaving non-resumable completed snapshots unchanged * More accurate messaging provider verification that maps messaging channels to expected gateway providers and skips tokenless channels (e.g., WhatsApp) * **Tests** * Added coverage for session repair edge cases, including resumable vs non-resumable complete snapshots and record-only resume scenarios * Expanded messaging provider verification tests, including tokenless channel handling <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Summary
Switch the live manual onboarding sequence to record-only step helpers while preserving compatibility for resume/ahead states. Machine transitions now come from returned FSM results rather than implicit step-helper movement.
Changes
OnboardRuntimeBoundarywithstepMutationOptions: { updateMachine: false }.preflightfrominitbefore invoking the first handler when applicable.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Bug Fixes
New Features
Tests