test(cli): cover policy mutation public route#4929
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Warning Review limit reached
More reviews will be available in 41 minutes and 2 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
E2E Scenario Advisor RecommendationRequired scenario E2E: None Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
PR Review AdvisorFindings: 0 needs attention, 0 worth checking, 0 nice ideas Consider writing more tests for
This is an automated advisory review. A human maintainer must make the final merge decision. |
Summary
This PR adds focused public CLI smokes for the sandbox-first built-in policy mutation routes after #4920 moved most confirmation coverage into same-process action tests. The tests keep coverage for dispatching
policy-add/policy-removethrough the user-facing route without restoring the old subprocess-heavy matrix.Related Issue
Part of #4892
Changes
test/cli/sandbox-mutations.test.ts.nemoclaw <sandbox> policy-add github --yesandnemoclaw <sandbox> policy-remove github -ymutate the temp registry through the public sandbox-first route.NEMOCLAW_NON_INTERACTIVE=1 nemoclaw <sandbox> policy-addfails before selecting or applying a preset.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com