Follow-up from @rng1995's review on #36:
#36 (review)
"The cleanup block duplicates the private _cleanup_result helper … RISK_THRESHOLD = 50 is duplicated from the CLI's inline 50"
Two small code-quality issues surfaced during review of #36:
RISK_THRESHOLD = 50 is duplicated between cli.py (inline) and mcp_server.py (module constant). If the threshold changes, both must be updated in sync.
- The temp-dir cleanup
finally block in mcp_server.py reimplements what _cleanup_result() in cli.py already does. The two can drift independently.
Proposed Fix
- Extract
RISK_THRESHOLD to a shared module (e.g. skillspector/constants.py) and import it in both files.
- Move
_cleanup_result to a shared utility module and import it in both places.
Follow-up from @rng1995's review on #36:
#36 (review)
Two small code-quality issues surfaced during review of #36:
RISK_THRESHOLD = 50is duplicated betweencli.py(inline) andmcp_server.py(module constant). If the threshold changes, both must be updated in sync.finallyblock inmcp_server.pyreimplements what_cleanup_result()incli.pyalready does. The two can drift independently.Proposed Fix
RISK_THRESHOLDto a shared module (e.g.skillspector/constants.py) and import it in both files._cleanup_resultto a shared utility module and import it in both places.