Adding ability to simulate an empty domain (no panels)#89
Draft
brookeslawski wants to merge 5 commits into
Draft
Adding ability to simulate an empty domain (no panels)#89brookeslawski wants to merge 5 commits into
brookeslawski wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to simulate an empty domain (or atmospheric boundary layer simulation) in PVade, meaning that there are no panels or other structures in the domain. The purpose of this capability is primarily for benchmarking and testing of the fluid and thermal solutions in a simplified, canonical setting. A user may want to use this capability to characterize the flow and thermal fields (e.g. velocity, temperature, turbulence profiles) of the domain in a precursor simulation before adding in the panels and running again.
Feature adds:
To do:
AttributeError: 'FSIDomain' object has no attribute 'structure'- it's looking for a structure mesh when it doesn't exist, only happens in 2d whenstructural_analysis=False-> need special treatment inMeshManager.py?structure) -> check and special treatment for calculatinghmin_local