From 5f3dbb05e44f3b5e6d9f7a7c841ba0b4df68edc0 Mon Sep 17 00:00:00 2001 From: "NathanNeurotic (Ripto)" <109461996+NathanNeurotic@users.noreply.github.com> Date: Mon, 20 Jul 2026 07:56:03 -0700 Subject: [PATCH 1/2] feat(defaults): every device on the Devices page ships OFF -- pure opt-in (NathanNeurotic directive) All start modes (BDM, APA HDD, Network, Apps, MMCE, Favourites) and all block-device toggles (USB, iLink, MX4SIO, exFAT HDD, UDPBD) now default to OFF/disabled. HDD, network, and the non-USB toggles already were; this flips BDM/Apps/MMCE/Favourites (were Manual) and USB (was on). A fresh install boots to the start menu with no tabs -- deferredInit's boot select handles the nothing-registered case explicitly ("the start menu stays") -- and the user enables exactly what their rig has in Settings. Saved configs override every one of these on load, so existing installs are untouched. The GUI-less autolaunch path (miniInit BDM force-enables) is deliberately untouched -- an external argv launch has no Settings screen to opt in with. Builds clean (make opl.elf, exit 0). Co-Authored-By: Claude Fable 5 --- src/opl.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/opl.c b/src/opl.c index 18b9efc2f..04654efc9 100644 --- a/src/opl.c +++ b/src/opl.c @@ -2879,12 +2879,16 @@ static void setDefaults(void) gXSensitivity = 1; gYSensitivity = 1; - gBDMStartMode = START_MODE_MANUAL; - gHDDStartMode = START_MODE_DISABLED; // RiptOPL: APA/PFS HDD OFF by default (was Manual); user opts in - gETHStartMode = START_MODE_DISABLED; // RiptOPL: network/SMB OFF by default (was Manual); user opts in - gAPPStartMode = START_MODE_MANUAL; - gMMCEStartMode = START_MODE_MANUAL; - gFAVStartMode = START_MODE_MANUAL; + // RiptOPL doctrine (NathanNeurotic, 2026-07-20): EVERY device on the Devices page ships OFF -- the + // user opts in to exactly what their rig has. A fresh install boots to the start menu with no tabs + // (deferredInit's boot select handles the nothing-registered case explicitly) and the user enables + // devices in Settings. Existing saved configs override all of these on load. + gBDMStartMode = START_MODE_DISABLED; + gHDDStartMode = START_MODE_DISABLED; + gETHStartMode = START_MODE_DISABLED; + gAPPStartMode = START_MODE_DISABLED; + gMMCEStartMode = START_MODE_DISABLED; + gFAVStartMode = START_MODE_DISABLED; gMMCESlot = 2; //Default to first Auto slot gMMCEIGRSlot = 3; @@ -2899,7 +2903,7 @@ static void setDefaults(void) gMMCEAckWaitCycles = 5; gMMCEUseAlarms = 1; - gEnableUSB = 1; + gEnableUSB = 0; // all block-device toggles OFF by default too (same opt-in doctrine) gEnableILK = 0; gEnableMX4SIO = 0; gEnableBdmHDD = 0; // exFAT BDM HDD OFF by default (the other "HDD type"; APA/PFS is gHDDStartMode above) From 61036e74e7db01cb3762d7f4d2a77e560a364e3e Mon Sep 17 00:00:00 2001 From: "NathanNeurotic (Ripto)" <109461996+NathanNeurotic@users.noreply.github.com> Date: Mon, 20 Jul 2026 09:16:35 -0700 Subject: [PATCH 2/2] style(opl): align the gEnableUSB comment per CI clang-format 12 (applying the runner's exact diff) Co-Authored-By: Claude Fable 5 --- src/opl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opl.c b/src/opl.c index 04654efc9..1239c710c 100644 --- a/src/opl.c +++ b/src/opl.c @@ -2903,7 +2903,7 @@ static void setDefaults(void) gMMCEAckWaitCycles = 5; gMMCEUseAlarms = 1; - gEnableUSB = 0; // all block-device toggles OFF by default too (same opt-in doctrine) + gEnableUSB = 0; // all block-device toggles OFF by default too (same opt-in doctrine) gEnableILK = 0; gEnableMX4SIO = 0; gEnableBdmHDD = 0; // exFAT BDM HDD OFF by default (the other "HDD type"; APA/PFS is gHDDStartMode above)