Skip to content

Commit 2290c2e

Browse files
author
farfromrefuge
committed
Merge remote-tracking branch 'nativescript/main'
2 parents 561fae1 + 0ec3b5e commit 2290c2e

6 files changed

Lines changed: 178 additions & 153 deletions

File tree

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
## [8.6.4](https://github.com/NativeScript/nativescript-cli/compare/v8.6.3...v8.6.4) (2024-01-17)
2+
3+
4+
### Bug Fixes
5+
6+
* skip log-source-maps for large files ([#5780](https://github.com/NativeScript/nativescript-cli/issues/5780)) ([c53b4e9](https://github.com/NativeScript/nativescript-cli/commit/c53b4e9111f3da98547ec273c92a73ead89aca13))
7+
8+
9+
110
## [8.6.1](https://github.com/NativeScript/nativescript-cli/compare/v8.6.0...v8.6.1) (2023-10-23)
211

312

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
---
1616

17-
[![nativescript -> npm](https://github.com/NativeScript/nativescript-cli/actions/workflows/npm_release.yml/badge.svg)](https://github.com/NativeScript/nativescript-cli/actions/workflows/npm_release.yml)
17+
[![nativescript -> npm](https://github.com/NativeScript/nativescript-cli/actions/workflows/npm_release_cli.yml/badge.svg)](https://github.com/NativeScript/nativescript-cli/actions/workflows/npm_release_cli.yml)
1818

1919
Get it using: `npm install -g nativescript`
2020

@@ -96,7 +96,7 @@ The NativeScript CLI is available for installing as an npm package.
9696

9797
In the command prompt, run the following command.
9898

99-
OS | Node.js installed from http://nodejs.org/ | Node.js installed via package manager
99+
OS | Node.js installed from https://nodejs.org/ | Node.js installed via package manager
100100
---|---------------------|----
101101
Windows | `npm install nativescript -g` | `npm install nativescript -g`
102102
macOS | `sudo npm install nativescript -g --unsafe-perm` | `npm install nativescript -g`
@@ -265,7 +265,7 @@ The NativeScript CLI calls the SDK for the selected target platform and uses it
265265

266266
When you build for iOS, the NativeScript CLI will either build for a device, if there's a device attached, or for the native emulator if there are no devices attached. To trigger a native emulator build when a device is attached, set the `--emulator` flag.
267267

268-
> **IMPORTANT:** To build your app for an iOS device, you must configure a valid certificate and provisioning profile pair, and have that pair present on your system for code signing your application package. For more information, see [iOS Code Signing - A Complete Walkthrough](http://seventhsoulmountain.blogspot.com/2013/09/ios-code-sign-in-complete-walkthrough.html).
268+
> **IMPORTANT:** To build your app for an iOS device, you must configure a valid certificate and provisioning profile pair, and have that pair present on your system for code signing your application package. For more information, see [iOS Code Signing - A Complete Walkthrough](https://seventhsoulmountain.blogspot.com/2013/09/ios-code-sign-in-complete-walkthrough.html).
269269
270270
[Back to Top][1]
271271

@@ -355,10 +355,10 @@ This software is licensed under the Apache 2.0 license, quoted <a href="LICENSE"
355355
[Back to Top][1]
356356

357357
[1]: #nativescript-command-line-interface
358-
[2]: https://www.progress.com/nativescript
358+
[2]: https://nativescript.org
359359
[3]: https://github.com/nativescript/docs
360360
[4]: https://docs.nativescript.org/
361361
[5]: https://docs.nativescript.org/api-reference
362362
[6]: https://www.nativescript.org/faq
363363
[7]: https://docs.nativescript.org/core-concepts/technical-overview
364-
[8]: http://blogs.telerik.com/valentinstoychev/posts.aspx/14-06-12/announcing-nativescript---cross-platform-framework-for-building-native-mobile-applications
364+
[8]: https://www.telerik.com/blogs/announcing-nativescript---cross-platform-framework-for-building-native-mobile-applications

lib/services/log-source-map-service.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,15 @@ export class LogSourceMapService implements Mobile.ILogSourceMapService {
6969
if (!this.$fs.getFsStats(filePath).isDirectory()) {
7070
const mapFile = filePath + ".map";
7171
let sourceMapRaw;
72+
73+
// Skip files bigger than 50MB
74+
if (this.$fs.getFileSize(filePath) > 50 * 1000 * 1000) {
75+
this.$logger.trace(
76+
`Skipping source map for file ${filePath} because it is too big (> 50MB).`
77+
);
78+
return;
79+
}
80+
7281
const source = this.$fs.readText(filePath);
7382
if (this.$fs.exists(mapFile)) {
7483
sourceMapRaw = sourceMapConverter.fromMapFileSource(

0 commit comments

Comments
 (0)