Skip to content

Commit 6b25143

Browse files
committed
Merge remote-tracking branch 'origin/main'
2 parents 8223062 + 7f1d147 commit 6b25143

3 files changed

Lines changed: 21 additions & 18 deletions

File tree

lib/definitions/project.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ interface INsConfigPlaform {
104104
interface INsConfigIOS extends INsConfigPlaform {
105105
discardUncaughtJsExceptions?: boolean;
106106
runtimePackageName?: string
107+
cocoapodUseBundleExec?: boolean
107108
}
108109

109110
interface INSConfigVisionOS extends INsConfigIOS {}

lib/services/cocoapods-service.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ export class CocoaPodsService implements ICocoaPodsService {
3535
private $logger: ILogger,
3636
private $config: IConfiguration,
3737
private $xcconfigService: IXcconfigService,
38-
private $xcodeSelectService: XcodeSelectService
38+
private $xcodeSelectService: XcodeSelectService,
39+
private $projectData: IProjectData,
3940
) {
4041
this.getCocoaPodsFromPodfile = _.memoize(
4142
this._getCocoaPodsFromPodfile,
@@ -59,8 +60,12 @@ export class CocoaPodsService implements ICocoaPodsService {
5960
projectRoot: string,
6061
xcodeProjPath: string
6162
): Promise<ISpawnResult> {
62-
this.$logger.info("Installing pods...");
63+
const cocoapodUseBundleExec = this.$projectData.nsConfig.ios?.cocoapodUseBundleExec;
6364
let podTool = this.$config.USE_POD_SANDBOX ? "sandbox-pod" : "pod";
65+
if (cocoapodUseBundleExec === true) {
66+
podTool = `bundle exec ${podTool}`
67+
}
68+
this.$logger.info(`Installing pods using "${podTool}"...`);
6469
const args = ["install"];
6570

6671
if (process.platform === "darwin" && process.arch === "arm64") {
@@ -71,7 +76,7 @@ export class CocoaPodsService implements ICocoaPodsService {
7176
// arch: posix_spawnp: pod: Bad CPU type in executable
7277
// in which case, we should run it natively.
7378
const res: string = await this.$childProcess
74-
.exec("arch -x86_64 pod --version", null, {
79+
.exec(`arch -x86_64 ${podTool} --version`, null, {
7580
showStderr: true,
7681
})
7782
.then((res) => res.stdout + " " + res.stderr)

lib/services/project-data-service.ts

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -625,24 +625,21 @@ export class ProjectDataService implements IProjectDataService {
625625
projectDir: string,
626626
platform: constants.SupportedPlatform
627627
): IBasePluginData {
628+
console.log('getInstalledRuntimePackage');
629+
let packageName: string[] = [];
630+
if (platform === constants.PlatformTypes.ios) {
631+
packageName.push(this.$projectData.nsConfig.ios?.runtimePackageName, constants.SCOPED_IOS_RUNTIME_NAME, constants.TNS_IOS_RUNTIME_NAME);
632+
633+
} else if (platform === constants.PlatformTypes.android) {
634+
packageName.push(this.$projectData.nsConfig.android?.runtimePackageName, constants.SCOPED_ANDROID_RUNTIME_NAME, constants.TNS_IOS_RUNTIME_NAME);
635+
} else if (platform === constants.PlatformTypes.visionos) {
636+
packageName.push(constants.SCOPED_VISIONOS_RUNTIME_NAME);
637+
}
628638
const runtimePackage = this.$pluginsService
629639
.getDependenciesFromPackageJson(projectDir)
630640
.devDependencies.find((d) => {
631-
if (platform === constants.PlatformTypes.ios) {
632-
const packageName = this.$projectData.nsConfig.ios?.runtimePackageName || constants.SCOPED_IOS_RUNTIME_NAME;
633-
return [
634-
packageName,
635-
constants.TNS_IOS_RUNTIME_NAME,
636-
].includes(d.name);
637-
} else if (platform === constants.PlatformTypes.android) {
638-
const packageName = this.$projectData.nsConfig.android?.runtimePackageName || constants.SCOPED_ANDROID_RUNTIME_NAME;
639-
return [
640-
packageName,
641-
constants.TNS_ANDROID_RUNTIME_NAME,
642-
].includes(d.name);
643-
} else if (platform === constants.PlatformTypes.visionos) {
644-
return d.name === constants.SCOPED_VISIONOS_RUNTIME_NAME;
645-
}
641+
return packageName.includes(d.name);
642+
646643
});
647644

648645
if (runtimePackage) {

0 commit comments

Comments
 (0)