fix: kill leaked analytics process

With recent changes, CLI's processService does not handle SIGINT signal, so it actually never sends Finish message to analytics process. CLI dies gracefully, but the analytics process is not killed. To fix this add `process.exit` in the analytics process when it receives disconnect event. Also remove all logic for Finish message as CLI will never send it.

Author: rosen-vladimirov

lib/common/declarations.d.ts

@@ -207,11 +207,6 @@ declare const enum TrackingTypes {
 	 * Defines that the broker process should get and track the data from preview app to Google Analytics
 	 */
 	PreviewAppData = "PreviewAppData",
-
-	/**
-	 * Defines that all information has been sent and no more data will be tracked in current session.
-	 */
-	Finish = "finish"
 }
 
 /**

lib/services/analytics/analytics-broker-process.ts

@@ -20,38 +20,17 @@ const analyticsBroker = $injector.resolve<IAnalyticsBroker>(AnalyticsBroker, { p
 
 let trackingQueue: Promise<void> = Promise.resolve();
 
-let sentFinishMsg = false;
-let receivedFinishMsg = false;
-
 const sendDataForTracking = async (data: ITrackingInformation) => {
 	trackingQueue = trackingQueue.then(() => analyticsBroker.sendDataForTracking(data));
 	await trackingQueue;
 };
 
 const finishTracking = async (data?: ITrackingInformation) => {
-	analyticsLoggingService.logData({ message: `analytics-broker-process finish tracking started, sentFinishMsg: ${sentFinishMsg}, receivedFinishMsg: ${receivedFinishMsg}` });
-
-	if (!sentFinishMsg) {
-		sentFinishMsg = true;
-
-		data = data || { type: TrackingTypes.Finish };
-		const action = async () => {
-			await trackingQueue;
-			analyticsLoggingService.logData({ message: `analytics-broker-process tracking finished` });
-			process.disconnect();
-		};
-
-		if (receivedFinishMsg) {
-			await action();
-		} else {
-			// In case we've got here without receiving "finish" message from parent (receivedFinishMsg is false)
-			// there might be various reasons, but most probably the parent is dead.
-			// However, there's no guarantee that we've received all messages. So wait some time before sending finish message to children.
-			setTimeout(async () => {
-				await action();
-			}, 1000);
-		}
-	}
+	analyticsLoggingService.logData({ message: `analytics-broker-process finish tracking started` });
+	await trackingQueue;
+	analyticsLoggingService.logData({ message: `analytics-broker-process tracking finished` });
+	process.disconnect();
+	process.exit();
 };
 
 const trackPreviewAppData = async (data: any) => {
@@ -84,12 +63,6 @@ const trackPreviewAppData = async (data: any) => {
 process.on("message", async (data: ITrackingInformation) => {
 	analyticsLoggingService.logData({ message: `analytics-broker-process received message of type: ${JSON.stringify(data)}` });
 
-	if (data.type === TrackingTypes.Finish) {
-		receivedFinishMsg = true;
-		await finishTracking(data);
-		return;
-	}
-
 	if (data.type === TrackingTypes.PreviewAppData) {
 		await trackPreviewAppData(<IPreviewAppTrackingInformation>data);
 		return;

lib/services/analytics/analytics-service.ts

@@ -13,7 +13,6 @@ export class AnalyticsService implements IAnalyticsService, IDisposable {
 
 	constructor(private $logger: ILogger,
 		private $options: IOptions,
-		private $processService: IProcessService,
 		private $staticConfig: Config.IStaticConfig,
 		private $prompter: IPrompter,
 		private $userSettingsService: UserSettings.IUserSettingsService,
@@ -228,15 +227,7 @@ export class AnalyticsService implements IAnalyticsService, IDisposable {
 
 					if (!isSettled) {
 						isSettled = true;
-
-						this.$processService.attachToProcessExitSignals(this, () => {
-							broker.send({
-								type: TrackingTypes.Finish
-							});
-						});
-
 						this.brokerProcess = broker;
-
 						resolve(broker);
 					}
 				}