Skip to content

Add core-js-pure to dependencies #295

Description

@djk01281

Problem

@naverpay/hidash@1.0.0's build output imports core-js-pure/... from 15 modules (30 files across .js and .mjs), but the published package.json has no dependencies field at all.

Consumers installing hidash under pnpm's isolated node_modules layout cannot resolve core-js-pure and hit MODULE_NOT_FOUND at runtime.

Cause

hidash is built with @naverpay/pite, which injects core-js-pure polyfills into the output. Any package whose build output imports another package must declare it as a runtime dependency so consumers can resolve it.

Fix

Add core-js-pure to dependencies and release:

{
  "dependencies": {
    "core-js-pure": "^3.39.0"
  }
}

>= 3.39.0 matches the version pite generates polyfill paths for; lower versions may be missing some files the build output references.

Related

A build-time check is being added to @naverpay/pite (see NaverPayDev/pite#101) so future builds catch this automatically.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions