fix(api): correct diagnostic messages

Keep logged IDs, limits, and regex details aligned with the operations that failed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5e77d279-9f4a-46bc-97b1-db6975c76faf

Author: AchoArnold

api/pkg/handlers/integration_3cx_handler.go

@@ -74,7 +74,7 @@ func (h *Integration3CXHandler) Messages(c fiber.Ctx) error {
 	request.Sanitize()
 	message, err := h.messageService.SendMessage(ctx, request.ToMessageSendParams(h.userIDFomContext(c), c.OriginalURL()))
 	if err != nil {
-		ctxLogger.Error(stacktrace.Propagate(err, "cannot send [3cx] message with paylod [%s]", c.Body()))
+		ctxLogger.Error(stacktrace.Propagate(err, "cannot send [3cx] message with payload [%s]", c.Body()))
 		return h.responseInternalServerError(c)
 	}
 

api/pkg/handlers/webhook_handler.go

@@ -159,7 +159,7 @@ func (h *WebhookHandler) Store(c fiber.Ctx) error {
 	}
 
 	if len(webhooks) == 10 {
-		ctxLogger.Warn(stacktrace.NewError("user with ID [%s] wants to create more than 5 webhooks", h.userIDFomContext(c)))
+		ctxLogger.Warn(stacktrace.NewError("user with ID [%s] wants to create more than 10 webhooks", h.userIDFomContext(c)))
 		return h.responsePaymentRequired(c, "You can't create more than 10 webhooks contact us to upgrade to our enterprise plan.")
 	}
 

api/pkg/repositories/gorm_user_repository.go

@@ -196,7 +196,7 @@ func (repository *gormUserRepository) Load(ctx context.Context, userID entities.
 	user := new(entities.User)
 	err := repository.db.WithContext(ctx).First(user, userID).Error
 	if errors.Is(err, gorm.ErrRecordNotFound) {
-		return nil, repository.tracer.WrapErrorSpan(span, stacktrace.PropagateWithCode(err, ErrCodeNotFound, "user with ID [%s] does not exist", user.ID))
+		return nil, repository.tracer.WrapErrorSpan(span, stacktrace.PropagateWithCode(err, ErrCodeNotFound, "user with ID [%s] does not exist", userID))
 	}
 
 	if err != nil {

api/pkg/services/service.go

@@ -30,9 +30,11 @@ func (service *service) createEvent(eventType string, source string, payload any
 }
 
 func (service *service) getFormattedNumber(ctxLogger telemetry.Logger, phoneNumber string) string {
-	matched, err := regexp.MatchString("^\\+?[1-9]\\d{9,14}$", phoneNumber)
+	const phoneNumberPattern = "^\\+?[1-9]\\d{9,14}$"
+
+	matched, err := regexp.MatchString(phoneNumberPattern, phoneNumber)
 	if err != nil {
-		ctxLogger.Error(stacktrace.Propagate(err, "error while matching phoneNumber [%s] with regex [%s]", phoneNumber, "^\\+?[1-9]\\d{10,14}$"))
+		ctxLogger.Error(stacktrace.Propagate(err, "error while matching phoneNumber [%s] with regex [%s]", phoneNumber, phoneNumberPattern))
 		return phoneNumber
 	}
 	if !matched {

api/pkg/validators/discord_handler_validator.go

@@ -96,8 +96,8 @@ func (validator *DiscordHandlerValidator) ValidateStore(ctx context.Context, req
 	}
 
 	if _, _, err := validator.client.Guild.Get(ctx, request.ServerID); err != nil {
-		ctxLogger.Error(validator.tracer.WrapErrorSpan(span, stacktrace.Propagate(err, "cannot fetch discord channel with ID [%s]", request.IncomingChannelID)))
-		result.Add("server_id", fmt.Sprintf("cannot fetch discord server with ID [%s] make sure the bot has access to the channel", request.ServerID))
+		ctxLogger.Error(validator.tracer.WrapErrorSpan(span, stacktrace.Propagate(err, "cannot fetch discord server with ID [%s]", request.ServerID)))
+		result.Add("server_id", fmt.Sprintf("cannot fetch discord server with ID [%s] make sure the bot has access to the server", request.ServerID))
 	}
 
 	return result
@@ -144,8 +144,8 @@ func (validator *DiscordHandlerValidator) ValidateUpdate(ctx context.Context, re
 	}
 
 	if _, _, err := validator.client.Guild.Get(ctx, request.ServerID); err != nil {
-		ctxLogger.Error(validator.tracer.WrapErrorSpan(span, stacktrace.Propagate(err, "cannot fetch discord channel with ID [%s]", request.IncomingChannelID)))
-		result.Add("server_id", fmt.Sprintf("cannot fetch discord server with ID [%s] make sure the bot has access to the channel", request.ServerID))
+		ctxLogger.Error(validator.tracer.WrapErrorSpan(span, stacktrace.Propagate(err, "cannot fetch discord server with ID [%s]", request.ServerID)))
+		result.Add("server_id", fmt.Sprintf("cannot fetch discord server with ID [%s] make sure the bot has access to the server", request.ServerID))
 	}
 
 	return result