Reset crosshair on resets to fix spectator non-matching-to-player xhair

This is kind of a guesswork if it'll fix the spectator seeing crosshair
on player that it's not the player's actual crosshair, but I'm assuming
the state haven't been refreshed properly especialy the timer till next
crosshair refresh and maybe on map change and where player index
changes it gets stuck with other player's crosshair.

* fixes #1735

Author: nullsystem

src/game/client/hud_crosshair.cpp

@@ -377,6 +377,17 @@ void CHudCrosshair::GetDrawPosition ( float *pX, float *pY, bool *pbBehindCamera
 ConVar cl_neo_scope_restrict_to_rectangle("cl_neo_scope_restrict_to_rectangle", "1", FCVAR_CHEAT,
 	"Whether to enforce rectangular sniper scope shape regardless of screen ratio.", true, 0.0, true, 1.0);
 
+#ifdef NEO
+
+void CHudCrosshair::resetPlayersCrosshair()
+{
+	V_memset(m_szLocalStrPlayersCrosshair, 0, sizeof(m_szLocalStrPlayersCrosshair));
+	V_memset(m_playersCrosshairInfos, 0, sizeof(m_playersCrosshairInfos));
+	V_memset(m_aflLastCheckedPlayersCrosshair, 0, sizeof(m_aflLastCheckedPlayersCrosshair));
+}
+
+#endif // NEO
+
 void CHudCrosshair::Paint( void )
 {
 	if ( !m_pCrosshair )
@@ -502,7 +513,6 @@ void CHudCrosshair::Paint( void )
 		if (bPlayerIdxValid)
 		{
 			bTakeSpecCrosshair = true;
-			m_playersCrosshairInfos;
 			bThisFrameRefreshCrosshair = false;
 			pCrosshairInfo = &m_playersCrosshairInfos[iPlayerIdx];
 			pszNeoCrosshair = pNeoPlayer->m_szNeoCrosshair.Get();

src/game/client/hud_crosshair.h

@@ -41,6 +41,8 @@ class CHudCrosshair : public CHudElement, public vgui::Panel
 	char m_szLocalStrPlayersCrosshair[MAX_PLAYERS][NEO_XHAIR_SEQMAX] = {};
 	CrosshairInfo m_playersCrosshairInfos[MAX_PLAYERS] = {};
 	float m_aflLastCheckedPlayersCrosshair[MAX_PLAYERS] = {};
+
+	void resetPlayersCrosshair();
 #endif
 
 	virtual void	SetCrosshairAngle( const QAngle& angle );

src/game/client/neo/c_neo_player.cpp

@@ -1605,6 +1605,11 @@ void C_NEO_Player::Spawn( void )
 				neoHud->resetHUDState();
 			}
 		}
+
+		if (CHudCrosshair *crosshair = GET_HUDELEMENT(CHudCrosshair))
+		{
+			crosshair->resetPlayersCrosshair();
+		}
 	}
 }